Here are some options for Claro 9.5 using the theme's white-in-green focus ring:
- Partial focus ring with round edge:
- Partial focus ring with square edge:
- Full focus ring with round edge:
- Full focus ring with square edge:
- Partial focus ring with round edge:
- @camilledavis opened merge request.
- Status changed to Needs review
over 1 year ago 5:01pm 31 March 2023 - ๐จ๐ฆCanada mgifford Ottawa, Ontario
Great to see movement here @camilledavis! Would be nice to be able to close some of these issues from the Before Times.
Can you provide before/after snapshots? You're providing a number of options.
Also looks like these are just CSS changes, there shouldn't be any semantic changes, just visual layout.
Also Andrew noted:
"I think the centred horizontal position could be an issue too. A safer placing would be the top corner of the viewport, not just top edge. CSS position:fixed + an high z-index should be enough, no?"I has this been addressed? It is difficult to see from the screenshot. If you need help with the bidirectional code, let me know.
Daniel also mentioned the BBC (usually pretty solid to follow their lead), and this is what they have used:
Here's a before/after for option 1
(The different options are just for focus ring style, in all 4 options the link is on the top left)
Before:
After:
- Status changed to Needs work
over 1 year ago 6:15pm 6 April 2023 - ๐บ๐ธUnited States smustgrave
Seems there is a build failure in the MR.
Also could the issue summary be updated to include the proposed solution please.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 10:51am 7 April 2023 - Status changed to Needs work
over 1 year ago 11:47am 7 April 2023 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- last update
over 1 year ago 30,322 pass - ๐จ๐ฆCanada mgifford Ottawa, Ontario
Adding WCAG SC 1.4.11 - https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast
- Merge request !5112Move claro skiplink to upper left and add green focus outline from theme. โ (Closed) created by camilledavis
- last update
about 1 year ago 30,434 pass - Status changed to Needs review
about 1 year ago 5:25pm 24 October 2023 Created MR for 11.x, just for Claro though. Wondering what to do about Olivero since the skiplink design is different. Would be good to have some input from designers...
- Status changed to Needs work
about 1 year ago 2:07pm 25 October 2023 - ๐บ๐ธUnited States smustgrave
Think the issue summary could use before/after screenshots of claro, and if not applicable if olivero is included.
- Status changed to Needs review
7 months ago 9:55pm 29 April 2024 - Status changed to RTBC
7 months ago 1:46pm 30 April 2024 - ๐บ๐ธUnited States smustgrave
Updated issue summary to use template.
Out of curiosity tried with new navigation module
Change looks good to me.
- Status changed to Needs work
7 months ago 11:34pm 4 May 2024 - ๐ซ๐ทFrance nod_ Lille
This fixes it in claro, need to fix umami, it does the same center positioning think as before. Olivero is fine (design is different but it's top-left aligned already)
- Status changed to Needs review
6 months ago 1:32pm 6 May 2024 - Status changed to Needs work
6 months ago 1:52pm 6 May 2024 - ๐บ๐ธUnited States smustgrave
Lets also include screenshots of umami since the change doesn't appear to be 1 to 1
No RTL needed for Umami?
- Status changed to Needs review
6 months ago 3:04am 7 May 2024 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have attached after patch screenshot for LTR & RTL.
- Status changed to RTBC
6 months ago 1:43pm 7 May 2024 - Status changed to Fixed
6 months ago 9:09pm 8 May 2024 - ๐ซ๐ทFrance nod_ Lille
Fixed css lint error on commit
Committed and pushed 5e0d1efa0a to 11.x and 0b36d01ad6 to 11.0.x and c1f7726488 to 10.4.x and 12b546ca74 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.