Empty #tag in HtmlTag causes <> to be printed at the top of the pages.

/** * Implements hook_page_attachments(). */ function adsense_page_attachments(array &$attachments) { $attachments['#attached']['html_head'][] = [ [ '#tag' => '', '#theme' => 'adsense_comment', '#comment' => 'adsense page-level ads: page not in match list', ], 'adsense_unmatched_page', ]; }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →

🇮🇳India sonam.chaturvedi Pune

Patch #16 applied successfully on 10.1.x-dev with one hunk.

Checking patch core/lib/Drupal/Core/Render/Element/HtmlTag.php...
Hunk #1 succeeded at 86 (offset -1 lines).
Checking patch core/tests/Drupal/Tests/Core/Render/Element/HtmlTagTest.php...
Applied patch core/lib/Drupal/Core/Render/Element/HtmlTag.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Render/Element/HtmlTagTest.php cleanly.

Comment over 1 year ago →
🇺🇸United States smustgrave
Triggering for D10 tests
Status changed to RTBC over 1 year ago2:36pm 1 March 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Tests passed fine for D10
Status changed to Needs work over 1 year ago11:24am 2 March 2023
Comment over 1 year ago →
🇬🇧United Kingdom catch
+++ b/core/lib/Drupal/Core/Render/Element/HtmlTag.php @@ -87,24 +87,32 @@ public static function preRenderHtmlTag($element) { + }
Why add the newline? Shouldn't this be a complete no-op?

Also should there be an assert() when this receives an empty tag? Right now this silently fails.
First commit to issue fork.
Comment over 1 year ago →
🇺🇸United States andy-blum Ohio, USA
Removing @Avanishyadav issue credit for opening empty MR