- π³πΏNew Zealand quietone
This was discussed at a coding standards meeting. #3380936: Coding Standards Meeting 2023-08-01 2100 UTC β where the following points were raised.
- This is referring to hook_help which is intended to be deprecated, π± Deprecate hook_help() and combine with Topics Active .
- Should the Help Topic standards be withing the Coding standard wiki pages. What is the history for having them separate? Should they be moved?
I've updated the Issue Summary. In doing so I have removed two of the requested changes because that section of documentation, the example, was deleted. See https://www.drupal.org/node/632280/revisions/view/12277977/12369190 β
- Status changed to Needs work
over 1 year ago 7:41am 14 August 2023 - π³πΏNew Zealand quietone
I now see that there is wiki page for ' Help Topic Standards β '. I think these changes should also go there. Or is there a better way to have the same information in two places?
Setting to NW
- Status changed to Needs review
over 1 year ago 3:28am 6 September 2023 - π³πΏNew Zealand quietone
Update the IS in preparation for announcing this one
- π«π·France andypost
This change is scriptable
core$ cat help.sh #!/bin/bash # Path to the Drupal root directory. DRUPAL_ROOT="/path/to/drupal" DRUPAL_ROOT="." # Function name pattern of hook implementations for hook_help. HOOK_HELP_PATTERN='function .*_help' # Find all files in the Drupal root directory. find "$DRUPAL_ROOT" -type f -name "*.module" | while read -r file; do # Check if the file contains the implementation of hook_help. if grep -q "$HOOK_HELP_PATTERN" "$file"; then # Use sed to replace <h3> with <h2> in the hook_help implementation. sed -i "/${HOOK_HELP_PATTERN}/,/^}/{s/<h3>/<h2>/g; s/<\\/h3>/<\\/h2>/g;}" "$file" echo "Updated $file" fi done echo "Done replacing <h3> tags with <h2> in hook_help implementations."
- Status changed to RTBC
12 months ago 9:26am 12 January 2024 - π³πΏNew Zealand quietone
This was discussed by the coding standards committee and we all agreed to do this.
I have updated the documentation per the issue summary.
- π³πΏNew Zealand quietone
We also agreed that this isn't a Coding Standards issue, so moving to the Core queue.
- π³πΏNew Zealand quietone
The followup to make the change is π Change help headings for WCAG 2.0 Active
- π³πΏNew Zealand quietone
Adding credit for the discussion amongst some coding standing committee members.
- Status changed to Needs work
12 months ago 1:13pm 12 January 2024 - π¬π§United Kingdom longwave UK
The patches are woefully out of date, please open a merge request instead and let's work on this against 11.x there.
- Status changed to RTBC
12 months ago 1:15pm 12 January 2024 - π¬π§United Kingdom longwave UK
Oh I see, we are scripting the changes instead. But if we are doing that in another issue, what's this issue for - only updating docs?
- π¬π§United Kingdom longwave UK
Hiding the patches so they don't confuse others like they did to me.
- Status changed to Needs work
12 months ago 5:11pm 14 January 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- π³πΏNew Zealand quietone
Yes, this is about documentation.
On reflection, the change record should be on this issue as it is the changing the Standards documentation.
- Status changed to Needs review
12 months ago 3:22am 15 January 2024 - Status changed to RTBC
11 months ago 12:26pm 15 January 2024 - Status changed to Fixed
11 months ago 2:57am 2 February 2024 - π³πΏNew Zealand quietone
@andypost, thank you!
The documentation is updated and the implementation issue is also complete. The remaining piece is to publish the CR and set this to Fixed. I double checked the docs and the CR and I don't see anything that needs to be changed. Since there has been no further feedback and even though I wrote the CR I am going to publish and set this to Fixed.
Thank you to everyone her for improving Drupal!
Automatically closed - issue fixed for 2 weeks with no activity.