Allow media entity reference fields to be displayed as a gallery in a colorbox

Hi everyone,

Thanks a lot for contributing this patch and a lot of help in this ticket with how to enable the colorbox module with various advanced setups, in particular using paragraphs or Media entity reference fields.

Please find attached to this comment a re-rolled patch addressing the last comment #41, where the support for `dompurify` was ported from 'ColorboxFormatter.php':
File attached as: 2957030-42-colorbox-entity_reference_formatter.patch →

Additionally, since 2.0.x has now become the default branch, the patch was rerolled for this branch and the version of the ticket updated.
 

Lastly, I would like to second the comment above at #39 and clearly state the patch is absolutely necessary if you're trying to build a more advanced gallery browsing experience, with pararaphs for example, from which the fields can be pulled and assembled with various values and logic in the preprocessing or theme layer.
On top of that, this patch really adds an amazing flexibility and functionality to the module, therefore, it would definitely make it much better.

We would greatly appreciate if a maintainer or someone with committing rights could please try taking a look at this patch and let us know if you would see anything that could prevent it from being added to the module.

Could you please give us your feedback and let us know if it is working as expected?

Feel free to let us know if you have any questions, requests or concerns on any aspects of this new patch or the ticket in general, we would be delighted to provide more information or take another look at the changes needed.
Thanks a lot to everyone for your great help and contributions.

5 years old now. Is this going to make it into a stable release? This module has limited to no usefulness these days if it doesn't support media entities.

#42 seems to be working well and I'll report back if I have any issues with the patch. Thanks everyone for your work!

PhotoSwipe → supports this.

Thanks @DYdave. patch in #42 works!

I had a problem with displaying double entities and a popup in inspect mode. Here is the corrected version.

I had a problem with displaying double entities and a popup in inspect mode. Here is the corrected version.

I've also been successfully using #42 for a client site for quite a while. It'd be great to get this in. There's now a 2.1.x branch, but sadly no 2.1.x version to use in issues. I'll convert this to an MR that merges cleanly to 2.1.x to hopefully move this forward. Stay tuned.

Okay, this is ready for review again. There's a lot of noise in the GitLab pipeline output, since the baseline 2.1.x runs are full of warnings. 😅 I fixed the new phpstan error introduced via this patch, but otherwise, I didn't touch anything to get the rest of the warnings green, since that'd all be scope creep in here.

Thanks a lot Derek (@dww)!

Great work putting together a merge request and we're certainly hoping this could land in the 2.1.x branch at some point 🤞

I didn't touch anything to get the rest of the warnings green, since that'd all be scope creep in here.

Following your comment, we've done a round of changes already and got everything fixed except ESLint, which is more complicated, would take more time and risk breaking things, otherwise, see:

• CSPELL: 📌 GitlabCI: Fix CSPELL validation errors Needs review
• PHPCS: 📌 GitlabCI: Fix PHPCS validation errors Needs review
• Stylelint: 📌 GitlabCI: Fix Stylelint validation errors Needs review

 
Feel free to let us know if you would need any help getting this one over the line or with any other issue in the module, we would surely be glad to help.
Thanks in advance for the reviews and feedback!

Thanks to everyone for their work on this. This is now committed.

Thanks a lot Paul (@paulmckibben)! 🙂

Super happy to see this issue finally making it into the the module 🎉

Thanks also very much for merging other merge requests and getting all the jobs (except ESLint) passing green 🟢
https://git.drupalcode.org/project/colorbox/-/pipelines/251999

Cheers!

Automatically closed - issue fixed for 2 weeks with no activity.