GitlabCI: Fix Stylelint validation errors

Created on 8 August 2024, 6 months ago
Updated 26 August 2024, 5 months ago

Problem/Motivation

The last pipeline for the current development branch 2.1.x reported quite a few errors for the job STYLELINT, see:

Steps to reproduce

Build > Pipeline > Run pipeline :
https://git.drupalcode.org/project/colorbox/-/pipelines
Select branch: 2.1.x

Proposed resolution

Fix all errors reported by STYLELINT:

  • Fix all prettier/prettier, order/properties-order, and other types of errors, based on report.
  • Ignore certain rules or errors if necessary to avoid breaking BC or causing legacy/compatibility issues.

 

Feel free to let us know if you have any questions or concerns on any aspects of this ticket or the project in general, we would be glad to help.
Thanks in advance!

πŸ“Œ Task
Status

Fixed

Version

2.1

Component

Code

Created by

πŸ‡«πŸ‡·France dydave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dydave
  • Pipeline finished with Failed
    6 months ago
    Total: 150s
    #248235
  • Pipeline finished with Success
    6 months ago
    Total: 152s
    #248253
  • Pipeline finished with Success
    6 months ago
    Total: 147s
    #248258
  • Status changed to Needs review 6 months ago
  • πŸ‡«πŸ‡·France dydave

    Quick follow-up on this issue:

    Fixed all stylelint validation errors based on report and required job to pass.

    Mostly automated fixes, except for the stylelint rule selector-id-pattern which had to be disabled in all reported CSS files:
    These CSS IDs can't really be changed since they are provided by the Colorbox JS library.

    In other words, changing these CSS IDs would break module's styles.

    Last pipeline with stylelint job completed successfully 🟒

     
    We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!38 and let us know if there would be any more work needed.

    Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or any aspect of this ticket in general, we would surely be glad to help.
    Thanks in advance for your feedback and reviews.

  • First commit to issue fork.
  • Status changed to Fixed 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States paulmckibben Atlanta, GA

    @DYDave, thanks for the patch! Merged MR 38.

  • Pipeline finished with Success
    6 months ago
    Total: 434s
    #254503
  • Pipeline finished with Success
    6 months ago
    Total: 295s
    #256875
  • Pipeline finished with Success
    6 months ago
    Total: 204s
    #256877
  • Pipeline finished with Failed
    6 months ago
    Total: 247s
    #256912
  • Pipeline finished with Success
    6 months ago
    Total: 191s
    #256917
  • Pipeline finished with Success
    6 months ago
    Total: 365s
    #256931
  • Pipeline finished with Success
    6 months ago
    Total: 155s
    #256961
  • Pipeline finished with Success
    6 months ago
    Total: 158s
    #257011
  • Pipeline finished with Success
    6 months ago
    Total: 166s
    #257014
  • Pipeline finished with Success
    6 months ago
    Total: 371s
    #257021
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024