- Issue created by @dydave
- Merge request !39Issue #3467008 by DYdave: CSpell on GitlabCI: Fixed all validation errors such... β (Merged) created by dydave
- Status changed to Needs review
5 months ago 10:44pm 8 August 2024 - π«π·France dydave
Quick follow-up on this issue:
A few additional commits were added to the current merge request MR!39 with a few comments, see above at #2.
But mostly, at this point:
Last build on MR!39: https://git.drupalcode.org/issue/colorbox-3467008/-/pipelines/248321- The CSPELL job now seems to be passing β
CSPELL job: https://git.drupalcode.org/issue/colorbox-3467008/-/jobs/2385512
- The PHPUnit Tests are passing as well π’ \o/
PHPUnit job: https://git.drupalcode.org/issue/colorbox-3467008/-/jobs/2385513
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on merge request MR!39 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - The CSPELL job now seems to be passing β
- Status changed to Needs work
5 months ago 1:49am 9 August 2024 - πΊπΈUnited States dww
Unfortunately the changes to the form elements and values makes this a more consequential and potentially breaking change. Eg anyone altering these forms will have to update code to match.
Probably better for now to ignore those spellings and open a follow up to rename these form elements with possible upgrade path if needed.
Otherwise, looks great.
Thanks!
-Derek - Status changed to Needs review
5 months ago 7:05am 9 August 2024 - π«π·France dydave
Thanks a lot Derek (@dww) for the very helpful review and speedy feedback, it's greatly appreciated! π
Unfortunately the changes to the form elements and values makes this a more consequential and potentially breaking change. Eg anyone altering these forms will have to update code to match.
Good catch! I had not thought about this one π
Changes to
src/Form/ColorboxSettingsForm.php
have been reverted and the wordsslideshowauto
andslideshowspeed
ignored in the file.Another breaking change:
https://git.drupalcode.org/project/colorbox/-/merge_requests/39/diffs?di...
Otherwise, that made me think of another breaking change to thecolorbox.install
file where the wordplease
was removed in at
function call, thus potentially breaking existing string translations:
I had a similar comment from Tim (@TR) at #3157138-19: GitlabCI: Fix CSPELL validation errors β , so disabling the ruleForbiddenWord
for this line seems like a better option for now.As suggested a follow-up task was created, see π CSPELL: Fix spelling for breaking variables and/or identifiers Active in case maintainers would still like to proceed with these changes.
Once again, we would greatly appreciate your reviews, comments and feedback.
Feel free to let us know if you would have any questions or concerns on any of the changes in the merge request or this ticket in general, we would be glad to help.
Thanks in advance! -
paulmckibben β
committed 197d7644 on 2.1.x authored by
DYdave β
Issue #3467008 by DYdave: CSpell on GitlabCI: Fixed all validation...
-
paulmckibben β
committed 197d7644 on 2.1.x authored by
DYdave β
- Status changed to Fixed
5 months ago 4:43pm 12 August 2024 - πΊπΈUnited States paulmckibben Atlanta, GA
@DYDave, thanks for cleaning this up, and @dww, thanks for reviewing. I have merged this MR.
Automatically closed - issue fixed for 2 weeks with no activity.