Unable to change non-translatable field value on translatable content with content moderation enabled

I highly recommend to avoid solution #3 (or #26) as removing constraints is not a solution, but workaround which can cause other issues.
Solution still needs to be found, or at least more precise log message in order to point developer in a right direction.
In my case, I was going through the /admin/config/regional/content-language list and check one by one entity and field so that brought me the result. I had some iframe field checked for translation and unchecking that field allowed me to translate content without issues.

This is raw decision for solution #a) (from description of this problem). Needs review this patch.

Some changes in patch. Fixed failed test issue.

The last submitted patch, 67: 2955321_content_moderation_content_translation_02.patch, failed testing. View results →

The patch #69 works well for me on D10.1.4

I've turned this into an MR and fixed some code style issues from the patch.

However, the PHPUnit tests are failing since the new code requires a service which is not available in the test context. I guess, this needs dependency injection instead of loading the service with \Drupal::service('...').

Phew, a couple of iterations and I got all the test green. This is now ready for review.

As a bug will need test coverage to make sure it doesn't break in the future.

Uploaded a patch for composer patches.

Fyi: The patch file is the history of all commits. Better is to use just the diff for composer-patches.

#77 is working for us. Thank you.

The patch is solving the issue but I have noticed a new Issue.

Steps to reproduce :

1. Add multilingual capability to site with at least 2 languages.
2. Have moderation enabled.
3. Create a node & publish in default language.
4. Go to node translate tab, Click on another language to add translation in NEW tab.
5. Try to add content - draft -> needs review -> Publish
6. But It wont allow to publish It throws error. - The submitted value needs_approval in the Change to element is not allowed.

The patch is solving the issue but I have noticed a new Issue.

Steps to reproduce :

1. Add multilingual capability to site with at least 2 languages.
2. Have moderation enabled.
3. Create a node & publish in default language.
4. Go to node translate tab, Click on another language to add translation in NEW tab.
5. Try to add content - draft -> needs review -> Publish
6. But It wont allow to publish It throws error. - The submitted value needs_approval in the Change to element is not allowed.

The patch is solving the issue but I have noticed a new Issue.

Steps to reproduce :

1. Add multilingual capability to site with at least 2 languages.
2. Have moderation enabled.
3. Create a node & publish in default language.
4. Go to node translate tab, Click on another language to add translation in NEW tab.
5. Try to add content - draft -> needs review -> Publish
6. But It wont allow to publish It throws error. - The submitted value needs_approval in the Change to element is not allowed.

#77 is giving me problems on a multilingual website with content moderation and paragraphs: when created the translation, paragraphs are not accessible anymore both on the default language as on the translation.

As per #2, I believe this is expected behaviour, and opting out of it for content moderated content probably isn't advisable, and would cause more issues.

I'd recommend that all development efforts are placed into 🐛 New non translatable field on translatable content throws error Needs work since that addresses the actual issue at hand (stopping it from applying data from non-translatable fields when they're inaccessible).

Depending on how the module works, using this patch can also result in loss of data if the widget returns an empty value when it detects that translations are unsupported as per my smart_date patch (which is probably why Paragraphs are a problem as per @stefvanlooveren - see #3194515-4: Smart Date Recurring doesn't work in non translatable field → )