- 🇮🇹Italy robertom
Patch 154 works well, but the part for altering metatags introduced in patch 147 is missing.
Attached the modified patch and the interdiff
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago run-tests.sh fatal error - 🇺🇦Ukraine mykola dolynskyi Poltava
@robertom invokation of metatags_alter(array &$metatags, array &$context) still not happening when called from JSON API endpoint
- First commit to issue fork.
- last update
over 1 year ago 370 pass, 6 fail - last update
over 1 year ago 370 pass, 4 fail - Status changed to Needs review
over 1 year ago 5:07pm 24 May 2023 - last update
over 1 year ago 371 pass, 2 fail The last submitted patch, 164: metatag-n2945817-164.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 5:22pm 24 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
Back to one test failure, the same issue reported in #73 - the cache context problems.
- Assigned to DamienMcKenna
- Status changed to Needs review
over 1 year ago 6:29pm 24 May 2023 - last update
over 1 year ago 375 pass, 1 fail The last submitted patch, 168: metatag-n2945817-168.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 371 pass, 2 fail - 🇺🇸United States DamienMcKenna NH, USA
In #3362522 I fixed the meta tag output so it's reliable, so now we can adjust the test coverage here.
- last update
over 1 year ago 377 pass - 🇺🇸United States DamienMcKenna NH, USA
Behold - the tests pass! Finally!
Would anyone care to give this a quick review? I think we can get it into the new release now.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 2:49pm 25 May 2023 - 🇺🇸United States apmsooner
Patch at #172 applies fine and works as intended for me.
- Status changed to Needs review
over 1 year ago 3:15pm 25 May 2023 - last update
over 1 year ago 372 pass, 2 fail - 🇺🇸United States DamienMcKenna NH, USA
Just to see what happens with the tests - let's mark the old classes as deprecated, rather than just removing them. Yes, this might blow up, overflow the bathtub and eat the key lime chocolate mousse my wife just made, but I'd like to properly deprecate-then-remove the classes if possible.
- 🇺🇸United States mglaman WI, USA
Yes, this might blow up, overflow the bathtub and eat the key lime chocolate mousse my wife just made
Seeing this sentence made me laugh and made my day.
Also, seeing this patch comes close. Deprecation sounds great, just in case someone is relying on them in quirky ways.
The last submitted patch, 176: metatag-n2945817-176.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 372 pass, 3 fail - 🇺🇸United States DamienMcKenna NH, USA
Reworking the test coverage so they're compatible with the legacy output.
The last submitted patch, 179: metatag-n2945817-179.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.-
DamienMcKenna →
committed 1c258071 on 2.0.x
Issue #2945817 by DamienMcKenna, mglaman, AndyF, yobottehg,...
-
DamienMcKenna →
committed 1c258071 on 2.0.x
- Status changed to Fixed
over 1 year ago 5:22pm 25 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
It has been a long, long, long time coming.
A huge and heartfelt Thank You!!! to everyone who worked on this over the years, who helped give us directions, answer questions, and pointed out bugs in the approach.
It's a little annoying to realize that had I just done #3362522 a few years ago this could have been committed ages ago, because at least some of the tests past 2020 were because the meta tags were out rendered in a reliable fashion. But hindsight is always 2020.
Anyway, I am truly grateful and appreciate you all.
Committed #172 to the 2.0.x branch and the removed APIs will be deprecated in 📌 Deprecate normalization plugins Fixed . Thank you all.
- 🇺🇸United States DamienMcKenna NH, USA
I've deprecated the APIs in #3362760 and we have a change notice for all of this.
If there are any further changes people can think of that might make this better, especially regarding documentation, please create follow-up issues or send me a message.
Again, thank you all.
- last update
over 1 year ago Patch Failed to Apply Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 7:13pm 30 November 2023