🇺🇦Ukraine @Mykola Dolynskyi

#8 worked

Still facing this in Drupal 9.5.2 in context of https://www.drupal.org/project/dashboards/issues/3294986 🐛 Error: Call to undefined method Drupal\dashboards\Entity\Dashboard Closed: works as designed

same problem, drupal 9.5.2

++ for #16, it worked, thanks @Henry Tran

Strange SMTP was working OK, but when I added MimeMail got this problem

same, if I set mailsystem formatter = Mime Mail mailer and Sender = SMTP mailer - I get subject error
If both SMTP mailer - mail sent OK and arrives, but no HTML
If both Mime Mail mailer - no errors, but email does not arrive

It does not go anywhere because debug print function is not implemented by SMTP module authors 

web/modules/contrib/smtp/src/Plugin/Mail/SMTPMailSystem.php

    // Turn on debugging, if requested.

    if ($this->smtpConfig->get('smtp_debugging')

      && $this->currentUser->hasPermission('administer smtp module')) {

      $mailer->Debugoutput = function($str, $level) {

// drupal set message $str

      };

      $mailer->SMTPDebug = TRUE;

    }

True, widget does not save selected with core field type daterange, but only with module provided daterange_timezone

@cilefen, @pradhumanjain2311 - thanks!

@cilefen I dont know how to do regression test. But the scenario to reproduce the problem is to install 4 modules mentioned in #0, then webform_rest/[anywebformhere]/fields?_format=json or similar will stop working throwing the exception "No route found for the specified format html. Supported formats: json, xml.".

Mykola Dolynskyi → created an issue.

@cilefen created MR for 10.3.x. Thanks for advice

@cilefen thanks for info, but I have to do this fix for 9.5 first. I cant run tests now for 10.x as too much modules to update for this project, but it will be done by end of year.

@cilefen my mistake, wrong lock file
its 9.5.2 actually.
And I believe situation is the same for Drupal 10 too, cause my stack is not very often used (basically must have REST on with EntityDomain to get this flow with problem)

Mykola Dolynskyi → created an issue.

Tried everything.
Only #64 works, thanks @khaldoon_masud

Geocoder 3.47

agreed. Spent 10 mins to figure out mystical meaning behind the "window"

Mykola Dolynskyi → created an issue.

adding patch

Mykola Dolynskyi → created an issue.

thanks @Rodlangh and @decloedt.simon@gmail.com
@borisson_ I dont remember already, but I believe not needed because tests were ok

adding patch which overcomes https://www.drupal.org/project/drupal/issues/3031271#comment-15257741 ✨ Support version negotiation for any entity type (currently only Node & Media are supported) Fixed

It basically ignores parent part of access check if parent is null

update to https://www.drupal.org/project/drupal/issues/3031271#comment-14884943 ✨ Support version negotiation for any entity type (currently only Node & Media are supported) Fixed - it was working good, until we deleted some nodes which share the paragraph

afterthat we getting

Error: Call to a member function getEntityType() on null in Drupal\jsonapi\Access\EntityAccessChecker>checkRevisionViewAccess() (line 249 of web/core/modules/jsonapi/src/Access/EntityAccessChecker.php)

    switch ($entity_type->id()) {
      case 'node':
      case 'media':
        $access = $entity->access('view all revisions', $account, TRUE);
        break;
      // Project-specific modification... Allow access to revisions of paragraphs
      // if the current user has access to the parent entity and to this
      // version of this paragraph. Note, this is not a perfect implementation.
      // Ideally we should be checking for access to the specific version of the
      // parent entity but there appears to be no way to do that with
      // information available at this point until
      // https://www.drupal.org/project/paragraphs/issues/2954512 is committed.
      case 'paragraph':
        assert($entity instanceof ParagraphInterface);
        $parent = $entity->getParentEntity();
        // Parent became grand parent
        while ($parent->getEntityType()->id() === 'paragraph') {
          $parent = $parent->getParentEntity();  // <--------- line 249
        }

Mykola Dolynskyi → created an issue.

adding patch for v 1.5, previous was for 1.x which differs

adding patch

@robertom invokation of metatags_alter(array &$metatags, array &$context) still not happening when called from JSON API endpoint

@Rajeshreeputra that does not match v2.0.4

    if (preg_match('/(^\/'.$domain_suffix.'(\s+)?(\r\n|\r|\n|$)+)|(^\/'.$domain_suffix.'\/(.+))/i', $path, $matches)) {
      $path = preg_replace('@^/' . $domain_suffix . '(.*)@', '$1', $path);
    }

Mykola Dolynskyi → created an issue.

Core firing hook_entity_insert() and hook_entity_insert() before transaction is finished may be not so bad, but bad there are no same hooks to be fired after transaction finished and no tables locked!

#4 does not work not for 'date' not for 'datetime'
format keeps rendered mm/dd/YY

made a crutch https://www.drupal.org/project/drupal/issues/2852107#comment-14940573 🐛 PathValidator::getUrlIfValid() does not support non-HTML/non-GET routes Active

had such issue, first request respects _format=json and next for the same server invocations are not.

after wasted hours of tracing and debugging I ended up with adding custom middleware

<?php

namespace Drupal\xxx;

use Drupal\Core\Http\InputBag;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpFoundation\InputBag as SymfonyInputBag;

/**
 * FirstMiddleware middleware.
 */
class RequestFormatMiddleware implements HttpKernelInterface {

    /**
     * The kernel.
     *
     * @var \Symfony\Component\HttpKernel\HttpKernelInterface
     */
    protected $httpKernel;

    /**
     * Constructs the FirstMiddleware object.
     *
     * @param \Symfony\Component\HttpKernel\HttpKernelInterface $http_kernel
     *   The decorated kernel.
     */
    public function __construct(HttpKernelInterface $http_kernel) {
        $this->httpKernel = $http_kernel;
    }

    /**
     * {@inheritdoc}
     */
    public function handle(Request $request, $type = self::MASTER_REQUEST, $catch = TRUE) {

		if(empty($request->getRequestFormat(null)) && !empty($request->get('_format'))) {
			$request->setRequestFormat($request->get('_format'));
		}

		Request::setFactory(
			function ($query, $request, $attributes, $cookies, $files, $server, $content) {
				$current = \Drupal::request();
				if(empty($attributes['_format']) && !empty($current->getRequestFormat(null))) {
					$attributes['_format'] = $current->getRequestFormat(null);
				}
				$request = new Request($query, $request, $attributes, $cookies, $files, $server, $content);
				foreach (['request', 'query', 'cookies'] as $bag) {
					if (!($bag instanceof SymfonyInputBag)) {
					$request->$bag = new InputBag($request->$bag->all());
					}
				}
				return $request;
			}
		  );

        return $this->httpKernel->handle($request, $type, $catch);
    }

}

what this "Waiting for branch to pass" means at all? My previous merge and patch stuck there for 4 weeks with no step to actual testing. And new one right now is kinda to be the same.

@jcnventura re-enrolled
https://www.drupal.org/project/hubspot_forms/issues/3336554 🐛 API key sunset - expose API params to settings form + loop batch fetching Fixed

P.S. Why is this?
PHP 7.4 & MySQL 5.7, D9.4.8 Skipped, branch did not pass for 4 weeks

Should I click "Dont wait pass" button in my new MR above? Because it is likely to end with the same

adding changes as patch

Mykola Dolynskyi → created an issue.

latest update: v2 and v3 API are not able to fetch more than 100 forms, no matter how big number in `?limit=xxx` param
will do new merge request soon

https://www.drupal.org/project/drupal/issues/3031271#comment-13706800 ✨ Support version negotiation for any entity type (currently only Node & Media are supported) Fixed

@lois.chabrand , @PQ - thank you very much, with small changes that works good to drupal 9.5.2