Contrib.social

Umami theme hardcodes too many assumptions about the install profile and site configuration

Open on Drupal.org →
Created on 23 January 2018, over 7 years ago
Updated 10 July 2024, 10 months ago

This is sort of a meta-issue that I noticed while reviewing the Umami code (most likely, it needs to be broken up into sub-issues).

The profile and theme are really fantastic! But an overall trend I saw is that the theme hardcodes several assumptions about how the profile will be configured. Some examples:

  1. It hardcodes the placement of particular fields in the template files, thereby causing the reordering capability of Drupal's "Manage Display" screen to not work correctly. This was noted at https://www.drupal.org/project/drupal/issues/2904243#comment-12346261 → and subsequent comments such as https://www.drupal.org/project/drupal/issues/2904243#comment-12408008 → previously, but I don't think there's an issue for it.
  2. In general, the theme has a lot of code designed to work with specifically-named fields. So if a site administrator tried to recreate some aspect of the profile with different field names, the styling would be off.
  3. There are a number of images shipped with the theme, some of which would make more sense as content so that they could be configured, or be used if the site switches to a different theme.

One result of this is that if, for example, you install the profile and then switch to a different theme (such as Bartik) it looks really bad. I wouldn't expect it to look beautiful, of course, but it would be nice if it were at least roughly functional. (Although in fairness, a lot of these problems might be either Bartik's fault or due to the fact that the themes have different region names so the blocks get switched to unusual places in Bartik.)

More generally, the goal of this profile is an "Out of the Box" demo, but:

  • If a lot of custom code in the theme is required to achieve the goals of the profile, then it doesn't really demo what Drupal does "out of the box".
  • If it causes some of Drupal's standard admin functionality to not work correctly, then it's not really an effective "demo" of Drupal's content-management and site-building capabilities.
🐛 Bug report
Status

Active

Version

11.0 🔥

Component
Umami  →

Last updated about 1 month ago

Created by

🇺🇸United States David_Rothstein

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Merge request !8727Clean up .theme file - #2938911 → (Open) created by finnsky
  • Pipeline finished with Success
    10 months ago
    #220414
  • Pipeline finished with Success
    10 months ago
    Total: 461s
    #220425
  • Pipeline finished with Failed
    10 months ago
    Total: 457s
    #220432
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇷🇸Serbia finnsky

    I've replaced 3 preprocesses with css only

  • Pipeline finished with Success
    10 months ago
    Total: 2628s
    #220481
  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇺🇸United States smustgrave

    Briefly looking at the MR and the title/summary and not super clear what is being fixed, I see it's moving some css around in the MR. So tagged for both.

  • Status changed to Postponed: needs info about 2 months ago
  • Comment about 2 months ago →
    🇦🇺Australia acbramley

    I would be inclined to close this as works as designed. As far as I know, Umami is for demonstration purposes only. The profile has "Expiermental" in the name and the description denotes it is to "show off some of Drupal's capabilities".

    I think trying to fix everything in the IS could be somewhat wasted effort. I don't think people are expected to install it, modify fields, config, etc and have it continue to work perfectly. Same goes for installing it and then switching themes.

    Setting to PMNMI to see if anyone else feels similarly.

  • Comment about 2 months ago →
    🇷🇸Serbia finnsky

    I might need to move what I did into a separate task.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024