An infinite loop in ViewsJoin could cause denial of service

Moved to MR and rerolled

Hiding patches for clarity.

Started the issue summary update but not as familiar with the issue so left TBD in sections that I couldn't answer. Is the proposed solution correct? Steps to reproduce?

Updated the IS

Thanks. Not sure because this is testing an infinite loop but when I tried to run the test-only feature it got hung up but did see an "E" in the output to show the failure.

So clearly test coverage is there haha.

Looking at the code change seems to appropriately catch the issue and throws the new exception.

Marking it but do new exceptions need a CR?

I've added some comments to the MR.

Addressed feedback. Not sure if the minor scope creep for php-stan is better than updating the base line and fixing it later, but it seems pretty minor so went for the fix

Feedback around the return null appears to have been addressed.

I'm triaging RTBC issues → . I read the IS and the comments and the MR. I didn't find any unanswered questions or other work to do.

However, I left one small suggestion for a comment in the MR. So setting back to NW for someone to check that suggestion.