Toolbar: Fix Code Style (Keep the code DRY)

Created on 23 September 2017, over 6 years ago
Updated 26 January 2023, over 1 year ago

Keep the code DRY :)

I'm optimizing Toolbar module and break down the parts into a small patch in favor of easier reviewing.

The patch using `format-patch` to generate. Please read each commits message inside the patch to understand what's going on.

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
ToolbarΒ  β†’

Last updated about 5 hours ago

  • Maintained by
  • πŸ‡«πŸ‡·France @nod_
Created by

πŸ‡­πŸ‡°Hong Kong droplet

Live updates comments and jobs are added and updated live.
  • Quick fix

    Very small and simple change. Preferred over Quickfix.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    Tagging for issue summary update about what this ticket is trying to accomplish. Never heard of "code dry" sorry.

    Also I imagine for D10 the scope of what this is fixing may have changed so that should be documented too please.

    Thanks!

Production build 0.69.0 2024