SQL rewrite warning falls out of sync with setting status

Problem/Motivation

The Views UI "SQL rewrite" warning toggles between shown and hidden states when the "Disable SQL Rewriting" box is checked/unchecked, but it doesn't take into account the actual status of the setting.

As a result, the warning can easily fall out of sync with the selected setting. This may mislead users into thinking the safer setting is unsafe and vice versa.

Steps to reproduce

1. Create a new basic view.
   • Show: Content
   • Type: All
2. In the view configuration page, open Query settings.
3. Check the "Disable SQL Rewriting" box. SQL rewrite warning is shown (Expected)
4. Click "Apply"
5. Open Query settings again.
6. Uncheck the "Disable SQL Rewriting" box. SQL rewrite warning is shown (Unexpected)

Proposed resolution

Check if the "Disable SQL Rewriting" box is actually checked before showing the warning.

Remaining tasks

• Review patch.

User interface changes

Display warning only when relevant - when user checks "Disable SQL Rewriting" option.

API changes

None.

Data model changes

None.