Fix 'Drupal.Commenting.DocComment.ShortNotCapital' coding standard

Revisiting this. I am still not sure about the postponing of this issue. The standard states

All summaries (first lines of docblocks) must be under 80 characters, start with a capital letter, and end with a period (.).

For me, that means that the rule is, in fact, following the standard.

And further, I don't think that the changes made here are following the standard for callbacks → either.

I am going to split this into two issues, one for the non-callbacks and one for the callbacks.

Looks like the last run on the merge request has some remaining failures, but I also have a question (posted on the MR).

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The remaining failures are expected because this issue is only for callbacks. The sibling issue needs to be committed first 📌 Fix 'Drupal.Commenting.DocComment.ShortNotCapital' coding standard except for callbacks Active .

But I wanted to see if these are correct in content and meet the special standard for callbacks.

Looks like the standard is indeed clear, but I didn't know that part of it, so for me this looks good.

Actually, I think I can rtbc this, as long as the committers know this can only be committed after the sibling issue.

committed sibling issue, merge conflict to resolve now :)

Rebased and fixed all violations for callbacks. Any other violations will be handled in a separate issue.

Since it is now possible to enable the sniff in most of core, this does change the phpcs.xml.dist

Ok, back to rtbc it goes.

nod_ → closed merge request !540

Committed 52e18cc and pushed to 11.x. Thanks!

There is a mistake in this commit, in ohpcs.xml.idst. Instead of adding this,

  <rule ref="Drupal.Commenting.DocComment">
    <exclude-pattern>core/tests/*</exclude-pattern>
  </rule>

it should have been

<rule ref="Drupal.Commenting.DocComment.DocComment.ShortNotCapital">
    <exclude-pattern>core/tests/*</exclude-pattern>
</rule>

Maybe this can be resolved in 📌 Enable 'Drupal.Commenting.DocComment.ShortNotCapital' coding standard for callbacks Postponed ?

Automatically closed - issue fixed for 2 weeks with no activity.