- 🇺🇸United States smustgrave
Thank you @kkalashnikov but the patch #8 still applied cleanly to 10.1 so the reroll was not needed. Removing credit for that.
You can verify if a patch still applies to a specific branch by clicking test/retest under it.Also with patches, even rerolls, please upload an interdiff
Thank you @nod_ for explaining that. So the documentation change in #8 looks good and simple then
Thanks
- 🇮🇳India kkalashnikov Ghaziabad, India
Hello @smustgrave this is the interdiff of #8 and #20 patch.
- Status changed to Needs work
almost 2 years ago 1:49pm 3 February 2023 - 🇬🇧United Kingdom catch
#19 still needs to be addressed - the comment should explicitly say these are libraries, and use attach/attached/#attached instead of 'include'.
- Status changed to Needs review
almost 2 years ago 7:37am 6 February 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #8 by addressing #23, please review it.
- Status changed to RTBC
almost 2 years ago 8:40pm 1 March 2023 - 🇺🇸United States smustgrave
Not sure if that can be cleaned up more but adds value as is currently.
- Status changed to Needs work
almost 2 years ago 9:36am 2 March 2023 - 🇬🇧United Kingdom catch
It still doesn't say explicitly that these are libraries. like 'you will need to attach the libraries .... to the form' or something.
- 🇺🇸United States timodwhit
The pull request/solution no longer seems valid: https://www.drupal.org/node/3293156 →
The user would need to create a new library for jquery.form and then attach it to the form it appears.
- 🇮🇳India bhanu951
I think we can close it as a duplicate of 🐛 Ajax error ajax.$form.ajaxSubmit() is not a function Needs work as it has working patch.