- 🇮🇳India Akram Khan Cuttack, Odisha
Added updated patch fixed remaining issue
- Status changed to Needs work
about 2 years ago 10:18am 21 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 5:31pm 19 December 2023 - 🇮🇳India zkhan.aamir
The patch in comment #5 is applying cleanly.
All the error have been fixed.
Please refer the screenshot. - Status changed to Needs work
over 1 year ago 7:17pm 9 January 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
$items['commerce-edinar/callback/setcmd'] = $items['commerce_edinar/callback/setcmd'] = array( 'page callback' => 'commerce_edinar_callback', + // Please add comment manually here. 'access callback' => TRUE,
The comment does not explain why the the page callback does not apply any access restriction.
- // @TODO: LAYOUT settings + // @todo LAYOUT settings
What follows
@todo
must be a sentence: It starts with a capitalized word and it ends with a period (preferably), an exclamation mark, or a question mark. It must also describe what needs to be done. - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ // No access restriction applied intentionally. Access is allowed for all + // users. 'access callback' => TRUE,
That is still not saying why the access is not restricted. It can be intentional, but it does not say what the intention is.
- // @TODO: LAYOUT settings - $form['#submit'][] = 'commerce_edinar_settings_form_submit'; + $form['#submit'][] = 'commerce_edinar_settings_form_submit'; + // @todo Review and implement layout settings for improved user experience. return $form;
The
@todo
comment should still be before the line setting the submission handler, as it is now. - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 6:00am 21 February 2024