Rename "STAGED" to "To be imported" on the config sync view differences modal

Well ... alternate implementations could store the things in other places. Like active configuration could be in Redis and the staged configuration could be from something other than a file system. At best maybe we should ask the storages for the labels.

That can happen?

For #62.

Issue summary should be updated to match.

Occam's razor, general UI wisdom, and core scope management all suggest that less is more. 😅 I just read the whole comment thread in here (thanks, everyone!), and I think "maybe we should ask the storages for the labels." is going to over-complicate things. I think the combo of #28 and #54 would be just:

Active | To be imported

No change to "Active", only change "Staged" to be a bit more self-documenting. Once you close the modal, the submit button the form says "Import all", so "To be imported" helps tie it all together.

Here it is in patch form. Updated summary to match.

Updating title to match current proposal. 😅 Hope no one minds. If folks don't like this and want to change 'Active', too, I'd be okay with renaming it to 'Current'. It's a slightly bigger change, and more of a translation impact (since we don't have t('Current') anywhere else in core, yet). I don't want this issue to stall out on the summary and title not matching the current proposal, but I'd be happy to implement an alternative if needed.

Thanks,
-Derek

The last submitted patch, 65: 2878040-65.patch, failed testing. View results →

Looks like a random fail:

Testing Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest
.....................E.                                           23 / 23 (100%)

Time: 06:36.360, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode with data set "with alignment" (true)
Behat\Mink\Exception\ElementNotFoundException: Element matching css "article.media--view-mode-view-mode-1" not found.

/var/www/html/vendor/behat/mink/src/WebAssert.php:418
/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php:1471

Re-queuing...

Simple change think goes long way!

Thanks for the RTBC! Added the UI change to the summary. 😅 Seems simple enough to not need screenshots...

Slightly more specific title, too: It's the config sync view differences modal, not the config sync form itself...

The last submitted patch, 65: 2878040-65.patch, failed testing. View results →

Super weird:

1) Drupal\Tests\node\Functional\NodeRevisionsTest::testRevisions
Drupal\Core\Config\PreExistingConfigException: Configuration objects (system.file) provided by system already exist in active configuration

However, on a fresh pull of 10.1.x, re-apply #65 locally, and NodeRevisionsTest passes just fine. Re-testing on the bot to see if that was a random fail or what.

Restoring RTBC since the bot is indeed happy.

This seems like a better description. Let's do it.

The last submitted patch, 65: 2878040-65.patch, failed testing. View results →

Sigh: more random fail.

I still stand by #38. The labels on the columns are confusing no matter what. It's the + and - symbols that tell you what is going to happen when you click the import all button.

There are improvements that we should make here though because there's a lot of other language on this modal and the page you click on to get the modal that should be improved.

Here are some thoughts.

• Change the title of the modal from "View changes of system.site" to "Proposed changes to system.site"
• Change the "view differences" button to "Review proposed changes"
• Change the help text "Compare the configuration uploaded to your sync directory with the active configuration before completing the import." to something more about reviewing proposed changes and then clicking the the "Import all" button
• Review the label of the "Import all" button
• Think about the Synchronize, Import, Export tasks - this gets confusing on the import because importing an archive means unpacking to the config sync directory whereas import single would actually import that to the active configuration.

Change the title of the modal from "View changes of system.site" to "Proposed changes to system.site"
Change the "view differences" button to "Review proposed changes"

Like both these suggestions

Change the help text "Compare the configuration uploaded to your sync directory with the active configuration before completing the import." to something more about reviewing proposed changes and then clicking the the "Import all" button

Like this idea but don't have any suggestion at this point.

Review the label of the "Import all" button

Maybe it should just say "Sync configuration"

Think about the Synchronize, Import, Export tasks - this gets confusing on the import because importing an archive means unpacking to the config sync directory whereas import single would actually import that to the active configuration.

Maybe the other tabs could be a follow up?

If in agreement this could go back to NW for the proposed changes.

Moving to NW for the points in #78