- 🇮🇳India TanujJain-TJ
tried to reroll the patch for drupal 10.1.x, please review.
- Status changed to Needs review
over 1 year ago 4:30pm 9 March 2023 - Status changed to Needs work
over 1 year ago 4:42pm 9 March 2023
As this issue completed.
#2869903: ContextualController: remove ContainerAwareTrait →
There was this insight
We should file a an new issue to move _contextual_id_to_links() into this controller. The controller is the only place this is used. And it makes the controller not unit testable.
There is also a maintenance hazard - in relation to php7.2 - http://php.net/manual/en/function.parse-str.php
for the php_parse() function we must always supply a second parameter
Warning
Using this function without the result parameter is highly DISCOURAGED and DEPRECATED as of PHP 7.2.
Needs work
10.1 ✨
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
tried to reroll the patch for drupal 10.1.x, please review.