- Merge request !1518Issue #2862702: PrepareModulesEntityUninstallForm::formTitle does not exist β (Open) created by hswong3i
- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
Left a few comments in the MR.
Also needs issue summary update per #33 - First commit to issue fork.
- Status changed to Needs review
8 months ago 2:56am 22 March 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
@dscl and I worked on this at DrupalSouth
it is ready for review now - Status changed to Needs work
8 months ago 3:24am 22 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
FWIW the test passes without the fix. That's because we're not actually calling any code results in the title callback being used.
Maybe we should go back to #3. Does this page actually need a title callback - hmmm maybe we do as I guess Easy Breadcrumb is using it.
Anyway to test this we need to use the title resolver service on this route. Visiting the page won't trigger the code because of the #title in the form.
- Status changed to Needs review
7 months ago 8:55pm 5 April 2024 - Status changed to Needs work
7 months ago 1:01am 6 April 2024 - πΊπΈUnited States smustgrave
Only moving to NW for the issue summary update
Remove the _title_callback for this route and just replace it with a static title. The confirm form overrides this value anyway.
Is that still true?
- Status changed to Needs review
7 months ago 10:30pm 7 April 2024 - Status changed to RTBC
7 months ago 10:38pm 7 April 2024 - πΊπΈUnited States smustgrave
Thanks! Summary now appears to match the MR.
- Status changed to Fixed
7 months ago 7:30am 8 April 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.