Add orderby key to third party settings

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Reeolled.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

moving to NW for change record.

Added a CR. Back to rtbc.

+++ b/core/modules/system/system.post_update.php
@@ -51,3 +51,30 @@ function system_post_update_linkset_settings() {
+    // Resave configuration to ensure any new sorting is applied.
+    $config_factory->getEditable($config_name)->save();

During updates you need to save with trusted data set to TRUE otherwise you can get in the way of other updates. Therefore you need to do sort here. Also you should only same them if they have third party settings.

@ameymudras thanks for working on this. Please include interdiffs though to easily see the changes.

+ $config_factory->getEditable($config_name)->save(TRUE);
Seems to address #35

Since this was previously RTBC going to restore but do wonder about

unset($sandbox['config_names'][$key]);

+++ b/core/modules/system/system.post_update.php
@@ -58,6 +58,35 @@ function system_post_update_linkset_settings() {
+      $config_factory->getEditable($config_name)->save(TRUE);

Trusting the configuration here means that it will not sort. So this update function will not work. See discussions on 🐛 Consistently sort filter formats to simplify config exports Fixed for lots about this.

I think here we should change the update to do the sorting and continue to use the trusted data feature as this update should not be fixing other things.

We also need to add a sort to \Drupal\Core\Config\Entity\ConfigEntityBase::preSave() in the same place as we do the dependency sorting.

Removing the needs CR tag,