Contrib.social

Password and confirm password should be mandatory fields while setting up password using one time link following by email

Open on Drupal.org →
Created on 23 February 2017, over 7 years ago
Updated 16 August 2024, 2 months ago

Problem/Motivation

Clicking on the forgot password link it generate one time use password reset link which is send via mail. After clicking on the link we can see that Password and confirm password are not mandatory fields. Which misguides user at UX and functionality level.

Actual Result - The one time password generator link which has Password and confirm password is not compulsory.

Expected Result - When user follows one time link to set the password, 'Password' and 'Confirm Password' fields should be mandatory fields.

Steps to reproduce

  1. Install a new Drupal instance
  2. Installed Development Environment module, which allowed me to test the mail
  3. Created new user
  4. Reviewed site log report for One time link
  5. Click on one time login link
  6. Now View that password and required password field is not compulsory.

Proposed resolution

When user follows one time link to set the password, 'Password' and 'Confirm Password' fields should be mandatory fields.

Remaining tasks

Convert to an MR
Review

User interface changes

Before

After

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
User module  →

Last updated about 15 hours ago

Created by

🇮🇳India Archana.Phatangare

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 2 months ago →
    🇳🇿New Zealand quietone

    Converting this to an MR is a suitable for a novice, leaving the tag.

  • First commit to issue fork.
  • Merge request !9744Reroll the patch changes but in the gitlab workflow for easy PR. → (Open) created by Unnamed author
  • Comment 21 days ago →
    priscarabelli

    Can somebody test what I have done? This is my first ever commit to Drupal. :)

  • Comment 21 days ago →
    priscarabelli
  • Status changed to RTBC 3 days ago
  • Comment 3 days ago →
    🇺🇸United States smustgrave

    Hiding old patches and files

    Issue summary appears complete so removing that tag.

    Ran test-only feature and it failed but didn't output a failure so ran locally

    Behat\Mink\Exception\ResponseTextException: The text "Password field is required." was not found anywhere in the text of the current page.
/var/www/html/web/vendor/behat/mink/src/WebAssert.php:907
/var/www/html/web/vendor/behat/mink/src/WebAssert.php:293
/var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:979
/var/www/html/web/core/modules/user/tests/src/Functional/UserPasswordResetTest.php:143

    Looking at the change to core/modules/user/src/AccountForm.php and comment helps and makes sense to me.

    believe this is good.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024