- 🇺🇸United States smustgrave
new function should be typehinted.
Change record should be added also.Should be simple for someone to do.
- First commit to issue fork.
- Assigned to royalpinto007
- Issue was unassigned.
I've added type hint in the new method as per the comment #18, please review.
Still need work for change record.
- Status changed to Needs review
over 1 year ago 4:10am 27 February 2023 - Status changed to Needs work
over 1 year ago 6:51am 27 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 8:10am 27 February 2023 - Status changed to Needs work
over 1 year ago 8:24am 27 February 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
#[\ReturnTypeWillChange]
This tells us that the return type will be different soon. This is completely new code, so this is not the correct way to mark this.It needs to be array, in both the interface and the implementation I think?
