Empty language (langcode) field wrapper inserted into contact form

Patch no longer applies in Drupal 10.1

Re-rolled against 10.1

I've opened a MR for this if anyone cares to review:

https://git.drupalcode.org/project/drupal/-/merge_requests/9779

Use the MR as a patch:
https://git.drupalcode.org/project/drupal/-/merge_requests/9779.patch

There are a bunch of PHPUnit tests failing but I think they are unrelated to this specific change. Perhaps someone with better knowledge than me can take a look and check?

Issue summary should follow the standard issue template

As a bug will also need test coverage showing the problem.

Removing 'Needs issue summary update' tag. Not really dived in to writing core tests before. If I find time I will try but in the meantime if anyone else wants to get stuck in please do!!

Merged master into branch so that MR is mergeable and patch can still be applied to 11.x.

darren.fisher → closed merge request !10786

MR now applies against 11.1 but tests still failing! Tearing my hair out with this one!

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

darren.fisher → changed the visibility of the branch 2842405-empty-language-langcode to hidden.

darren.fisher → changed the visibility of the branch 2842405-empty-language-langcode to active.

darren.fisher → changed the visibility of the branch 2842405-hide-empty-langcode-wrapper to hidden.

I think this needs a fresh branch and merge request. I'll take a look

d.fisher → closed merge request !9779

And now tests are passing. This whole issue had got into a pickle but I think it's good to go now!

Here's a patch that applies to 11.2.3.

Patch doesn't apply. There seems to be a few changes between the system.module file in 11.x and 11.2.3.

Think this patch should work on 11.2.3.

Thanks for updating for 11.x, still appears to need test coverage

Okay. An update! Remove all patches and merge requests related to this issue in your project. It is my belief that as of core 11.2.3 this issue has been fixed elsewhere. With no patches or merge requests applied I no longer see the empty langcode wrapper on my site? Can anyone else confirm if this is true? If so this issue can be marked as fixed even though it wasn't our work here that resolved the issue. I hope this is the case as I really don't like the solution we are applying to resolve the initial issue.