Improve the exception message when an entity handler class does not exist

Akhil Babu → made their first commit to this issue’s fork.

Akhil Babu → changed the visibility of the branch 2820411-improve-the-exception to hidden.

Akhil Babu → changed the visibility of the branch 2820411-improve-the-exception to active.

I have updated the exception message as follows
When the handler does not exist: The "%s" entity type did not specify a %s handler.
When the handler class does not exist: The %s handler of the "%s" entity type specifies a non-existent class "%s".

But, not sure why the pipeline is failing.

It's a pain to find the failure in the logs -- in the raw log at https://drupal-gitlab-job-artifacts.s3.us-west-2.amazonaws.com/34/dd/34d... it's this:

Drupal\Tests\Core\Entity\EntityTypeManagerTest::testGetHandlerMissingHandler
Prophecy\Exception\Call\UnexpectedCallException: Unexpected method call on
Double\EntityTypeInterface\P6:
- getHandlerClasses(

)
expected calls were:
- getHandlerClass(
exact("storage")
)
- getLinkTemplates(

)
- getClass(

)
- setClass(
exact("Mock_EntityInterface_5a25fd53")
)

So the mock needs updating for the new method call.

Though I am surprised there is no test coverage of the exception message we're changing!

Thanks @joachim.
Fixed the test. Also added a new test for the new exception message.

For good practice as a novice task issue summary should follow the standard issue template.

Updated the issue summary. Moving back to needs review

Issue summary seems good.

@Akhil Babu just FYI this ticket was tagged novice, you did nothing wrong working on it, but based on the number of posts you now have and work on other tickets believe you should be good to work on non novice issues now. Good job!

Thanks for helping developers.

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.

I reviewed the MR and left suggestions, so setting to Needs work.

Thanks for reviewing. I've Committed the proposed changes. Moving back to Needs review

Feedback has been addressed.

Issue credits

Left some suggestions on the MR

Can we also get a follow-up for a similar fix in \Drupal\Core\Entity\EntityTypeManager::getFormObject (if one does not already exist).

I have updated the MR as per the review comments.
@larowlan The exception message in \Drupal\Core\Entity\EntityTypeManager::getFormObject also has to be updated when the form class does not exist. I have create a new issue for that. 🐛 Improve the exception message when an entity form class does not exist Active

Feedback appears to be addressed.

I reviewed this again and all I notice is that it would be helpful is we had standards for dataproviders. But that is something for the Coding Standards project.

Committed 5a571f6 and pushed to 11.x.
Committed ae84c94 and pushed to 10.2.x.

Thanks!

quietone → closed merge request !5673

Automatically closed - issue fixed for 2 weeks with no activity.