Around line 1420 in \Drupal\views\Plugin\views\field\FieldPluginBase::renderAsLink
A check for $url['host'] doesn't make sense becuase it's never set by UrlHelper::parse()
// Parse the URL and move any query and fragment parameters out of the path.
$url = UrlHelper::parse($path);
// Seriously malformed URLs may return FALSE or empty arrays.
if (empty($url)) {
return $text;
}
// If the path is empty do not build a link around the given text and return
// it as is.
// http://www.example.com URLs will not have a $url['path'], so check host as well.
if (empty($url['path']) && empty($url['host']) && empty($url['fragment']) && empty($url['url'])) {
return $text;
}
remove the check and fix the code comment
doit
none
none
none
Needs work
9.5
Last updated
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Simple test should be added for those throw exceptions.
Thanks!