The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 11:12am 31 January 2023 - 🇮🇳India kkalashnikov Ghaziabad, India
Re-roll patch for Drupal version 10.1.x
- Status changed to RTBC
over 1 year ago 9:55am 1 February 2023 - Status changed to Needs work
over 1 year ago 10:55am 21 February 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
This change will break quite a few modules. See https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs...
For example: https://git.drupalcode.org/project/xmlfeedviews/-/blob/1.0.x/src/Plugin/...
I think we need to check if the plugin implements the new interface and if not issue a deprecation but still call the method. And then in Drupal 11 do something different. I'm also not sure if silence is the correct option here. At the moment if the style plugin does not implement the attachTo() method you'll get a helpful error saying that it does not. With this patch you won't get any information as a developer that you should think about implementing this method.