Make Url::toString(TRUE) explicit by having a Url::generate() method, as well as having GeneratedUrl::toString

Created on 28 May 2016, over 8 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

$url->toString(TRUE)->getGeneratedUrl()
Seriously, what does TRUE even mean.

Proposed resolution

  • Add $url->generate()
  • Deprecate \Drupal\Core\GeneratedUrl::getGeneratedUrl() in favor of \Drupal\Core\GeneratedUrl::toString().
  • disputed: Deprecate \Drupal\Core\Url::toString() in favor of \Drupal\Core\GeneratedUrl::toString(). This will lead to longer constructs ($url->toString() becomes $url->generate()->toString()), but enables us to also deprecate MetadataBubblingUrlGenerator / the behind-the-scenes bubbling of metadata that has caused many LogicExceptions

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
BaseΒ  β†’

Last updated about 1 hour ago

Created by

πŸ‡©πŸ‡ͺGermany dawehner

Live updates comments and jobs are added and updated live.
  • DrupalWTF

    Worse Than Failure. Approximates the unpleasant remark made by Drupal developers when they first encounter a particular (mis)feature.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024