I know this is a bit incomplete. I'm just recording the general issue as a start. See 2717673 → for more information.
Prior to 2717673 → , the calculated dependencies of a comment type did not include the provider module of the target entity. It is likely that some sites have comment types where the provider module has been uninstalled leaving the comment type in an invalid state.
Following @catch's suggestion here → we need to understand the implications of this and decide on a course of action.
Write a test which creates a comment type, uninstalls the provider module and then tests some actions which fail. One action that fails is editing the comment type. That would be a good test to start with.
Create patch.
I don't think we can really "fix" the problem once it has occurred but we should be able to at least avoid fatal errors on the site.
Needs work
9.5
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
At this time we will need a D10.1 of this patch.
Also tagging for subsystem review on their thoughts.