Comment types do not declare a dependency on the module that provides the target entity type. Thus, if that module is installed, the comment type will remain and using it will lead to fatal errors.
Declare the dependency on the provider of the target entity type. In particular implement calculateDependencies() in CommentType. EntityDisplayModeBase::calculateDependencies() can be used as inspiration.
None.
None.
The fact that comment types now get appropriately deleted when a module is uninstalled is a change in behavior, but since the comment types that were previously left in the system were completely broken, I don't see how anyone can currently rely on that behavior. Thus, I do not see the need for a change record either.
Comment types have a new entry in their exported configuration dependencies.
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
At this time we will need a D10 MR of this issue.
Since it's been 5 years tagged for IS update if any of the remaining tasks have changed as the module has been updated some.