Update link templates of test entities

Do a search for entity_test/add' and 'entity_test_mulrevpub/add' believe all instances have been found.

There was a test failure. I rebased and updated another link.

Additional link change seems fine.

The changes to the link templates here look good, but I'm concerned about the impact on contrib modules that are using these entity types for their tests. This can be seen by the large number of changes in the MR to add the additional type to the URL.

Can we try to revert all of those changes, and as well as fixing the add-form template, add an add-page template (using the original URL).

For instances where there's only one bundle, that will wire up \Drupal\Core\Entity\Controller\EntityController::addPage which handily redirects to the add-form template when there is only one bundle. For the vast majority of tests, there will only be one bundle because of the default value in \entity_test_entity_bundle_info

We can then assess how many tests are still broken, but I suspect it will be dramatically less. That will give us confidence that this change won't break as many contrib tests as the current approach most likely will.

@larowlan, thanks.

Made changes asked for in #35.

Awesome, passes 🎉

Feedback appears to be addressed here

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebase with many conflicts due to 📌 Convert entity type discovery to PHP attributes Needs review

Rebase seems good.

Updated credits.

There's one here still using annotations that I think should be attributes?

It would be out of scope for this issue to convert an entity from annotations to attributes. That entity was added in 🐛 Cannot use UUID as entity ID Needs work and there is a comment there suggesting that the conversion could be done as part of deprecating annotations, [#33101701-50]. That seems reasonable for a test entity.

Yes you're correct, sorry for missing that was already using annotations rather than it being added here

Committed to 11.x
As we're in RC phase for 11.1 I think this doesn't meet the requirements for backport.

Thanks all 🏆️

larowlan → closed merge request !9192

Automatically closed - issue fixed for 2 weeks with no activity.