Method resetSize() in dialog.position.js is responsible to reposition and resize jQuery UI dialog on dialog content loading and later on screen resize events, etc.
The problem is that some dialog implementations (like entity_browser → ) are only setting maxHeight parameter and not the height parameter, and in that combination resetSize() method with fail to set maxHeight on dialog because of missing height parameter.
If we take a look at jQuery UI dialog source _size() method on line 792 we will see that if height option is not set to auto then min/maxHeight options will be ignored.
attributes:
class:
label: 'Class'
description: 'Add class attributes like use-ajax to enable modal functionality.'
data-toggle:
label: 'Data toggle'
description: 'Use data-toggle in conjunction with data-target for your own custom modal (e.g.: modal modal-lg)'
data-target:
label: 'Data target'
description: '#id for custom modal'
data-dialog-type:
label: 'Data dialog type'
description: 'For default modal reference (e.g.: modal)'
use-ajax and data-dialog-type modal to open a basic page content with text in it longer than the view port (e.g. a long About/Disclaimer or Lorem Ipsum).
<div class="drupal-modal--content"> and recognize the inserted element inline style="max-height:<em>YOURVIEWPORTHEIGHT</em> px". Disabling it makes the modal behave like expected.
Tested in Firefox
Adding
div#drupal-modal--content[style] {
max-height: none !important;
}to the own theme CSS or LESS/SASS can be considered to be a temporary work-around.
Set the height to auto when height is not provided but min or max is.
Test coverage
Needs work
11.0 🔥
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Triaging as a random target for bug smash initiative. Updated the IS with the default template, copying the steps to reproduce from #20. Adding "Needs tests" tags as per #22.
Is there a way to reproduce this just with core?
#12 Patch Test Failed so re-roll the Patch For 10.1.
Thanks for the patch! Applies & works as expected 👌