[meta] Determine whether run-tests.sh can trigger and report phantomjs and phpcs results

Created on 5 February 2016, over 8 years ago
Updated 24 July 2024, about 2 months ago

Problem/Motivation

In a meeting with the Drupal 8 core committers today, the DA infrastructure team raised that due to a combination of rising testbot costs and staff availability, it was not possible to implement DrupalCI support for phantomjs or phpcs testing in the near term in the proposed way.

Relevant issues:

Proposed resolution

One proposed workaround for this lack of resources for these critically needed testing improvements was that if the test runs could be triggered from run-tests.sh and their results reported in the standard XML format, then the tests could be run on DrupalCI in that way until the resources are available to implement it properly on DrupalCI.

There are many drawbacks to this workaround--for example, these test runs would be a part of every patch and branch test for every environment, which is a waste of resources since your coding standards cannot be right on MySQL but wrong on Postgres. However, these test runs should add a few minutes at most, so in the short term, it is affordable. If the cost became unacceptable (for example, the JS test suite grows and performs worse than expected), then that would be a clear signal that the next step would be to invest in proper DrupalCI support.

Another drawback is that run-tests.sh is not even a true shell script, but a PHP script. Yet another is that it would add a dependency on coder for the core script, which might mean either moving coder into core or treating it as a vendor library. There are more. But if we can trade an ugly, temporary workaround for having automated testing for these areas sooner rather than (much) later, that seems a worthwhile tradeoff.

Remaining tasks

  1. Determine if this is even feasible.
  2. File separate issues for implementing the phantomjs testing and for the phpcs testing, if possible.
  3. File postponed followup issue to remove the workaround.

User interface changes

N/A

API changes

At most additions.

Data model changes

N/A

🌱 Plan
Status

Closed: outdated

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated 17 minutes ago

Created by

πŸ‡ΊπŸ‡ΈUnited States xjm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    I've skimmed through the Issue Summary and comments and I think this is now outdated. The testing environment on DrupalCI with has evolved quite a bit since this was opened. For one, the linting was done as part of the testing. And most recently, Drupal completed the move to testing with GitLabCI. The Drupal wiki has more information about Automated testing. β†’ .

    Closing as outdated. If that is wrong, add a comment and set the status to 'active'.

Production build 0.71.5 2024