- Status changed to Needs work
about 2 years ago 8:33pm 6 February 2023 - πΊπΈUnited States smustgrave
Needs some work for coding standard failuer.
- First commit to issue fork.
- @rpayanm opened merge request.
- Status changed to Needs review
about 2 years ago 6:21pm 9 February 2023 - πΊπΈUnited States rpayanm
I rerolled the patch and tried to fix the coding standard failure, please review.
- Status changed to Needs work
about 2 years ago 8:52pm 16 February 2023 - Status changed to Needs review
about 2 years ago 4:32am 17 February 2023 - Status changed to Needs work
about 2 years ago 11:55am 17 February 2023 - πΊπΈUnited States smustgrave
The issue is being done in the MR which is on the right branch. Continue there please.
Hiding #67
- πΊπΈUnited States xjm
Thanks @Rishabh Vishwakarma for your interest working on this issue.
This patch has been converted to an MR, so posting additional patches of the MR (especially with the same failures) is not helpful. I am removing credit for the additional patch after #67.
So, I've removed the issue credit for that reroll. In the future, you can get credit for issues by reading the issue to understand its purpose, and taking into account all the discussion on the issue. More information on the issue credit guidelines β .
Thank you!
- Status changed to Needs review
about 2 years ago 2:05pm 24 February 2023 - Status changed to Needs work
about 2 years ago 7:26am 26 February 2023 - π³π±Netherlands Lendude Amsterdam
Needs work for the test nitpick, looks good otherwise
- π¦πΉAustria tgoeg
Sorry as maybe this might be a bit a little off-topic, but it might help others coming here searching for this.
I am trying to achieve the contrary, i.e. I want to do hide a field if it is empty and rewritten, but it does not work out as expected.
This does not work if twig debugging is enabled, see https://www.drupal.org/project/drupal/issues/2950758 β¨ Empty table cells never hidden if twig debug is true Needs work