- Status changed to RTBC
over 1 year ago 3:01pm 21 February 2023 - πΊπΈUnited States smustgrave
May not need usability review actually.
Change is better but not clear now you can do -2 -30 minutes combined now. Will see what the committer thinks.
- Status changed to Needs review
over 1 year ago 10:43pm 22 February 2023 - π¬π§United Kingdom alexpott πͺπΊπ
For me we should close this as "won't fix works as designed". I think the help is useful it is showing you that
-2 hours -30 minutes
is how to subtract 2 and a half hours using this field. Because-2 hours 30 minutes
will only subtract one and a half hours. - π³π±Netherlands Lendude Amsterdam
Hmm, I think our example here is a little obscure in syntax, even though it might be correct. But as it isn't an uncommon scenario to try and offset by parts of hours, and it has a weird-ish syntax, it does provide value. We might do a better job of explaining what the expected outcome of the value is maybe? If we want to do anything at all?
Should we close this and tag π Date/time Views filter tries strotime() relative to Unix epoch Needs work as needing to update these examples? If that lands we might be able to link to strtotime I think?
- πΊπΈUnited States smustgrave
If we think this won't make it I think moving that over makes sense.
- Status changed to Closed: won't fix
over 1 year ago 10:24am 24 February 2023 - π³π±Netherlands Lendude Amsterdam
Since the docs aren't wrong, moving this to a task.
Options I see:
- Remove the "-2 hours -30 minutes" example since its vague syntax (feels bad since it is a correct example)
- Add additional explanation to the "-2 hours -30 minutes" example at to the expected outcome, maybe explain that "-2 hours 30 minutes" does something else (feel over the top)
- Update π Date/time Views filter tries strotime() relative to Unix epoch Needs work to also update the examples provided, or link to strtotime docs (which currently doesn't provide an example like "-2 hours -30 minutes")
I'm going to implement 3, if somebody feel strongly that we should do another option, feel free to reopen this.