FieldUiLocalTask is using t() before the plugin definition is saved, rather than at run time with the current user's language

Created on 14 June 2015, over 9 years ago
Updated 11 April 2023, over 1 year ago

Problem/Motivation

Pwolanin and I were working on #2338081: Local Tasks, Actions, and Contextual links mark strings from derivatives (or alter hooks) as safe and translated β†’ and noticed that title in FielUILocalTask is save to plugin definition before displaying to user so it won't get translated properly at run time.

Proposed resolution

Don't call t() before saving to plugin definition but call it during run time
verify that current language are part of the cache context when plugins are rendered

Remaining tasks

User interface changes

API changes

πŸ› Bug report
Status

Closed: cannot reproduce

Version

9.5

Component
Field UIΒ  β†’

Last updated 1 day ago

Created by

πŸ‡ΊπŸ‡ΈUnited States kgoel

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks for reporting this issue. We rely on issue reports like this one to resolve bugs and improve Drupal core.

    As part of the Bug Smash Initiative, we are triaging issues that are marked "Postponed (maintainer needs more info)". This issue was marked "Postponed (maintainer needs more info)" almost a year ago and there has been no activity since that time.

    Since there weren't steps to reproduce the issue provided since the issue was postponed, I'm marking the issue "Closed (cannot reproduce)". If anyone can provide complete steps to reproduce the issue (starting from "Install Drupal core"), document those steps in the issue summary and set the issue status back to "Active" [or "Needs Work" if it has a patch, etc.].

    Thanks!

Production build 0.71.5 2024