Move all JS in modules to a js/ folder

Opened 📌 Add a deprecation support for library-overrides Active for deprecation/bc support.

I converted the latest patch to an MR.
There were conflicts in the following, but it was a simple conversion.

• ./core/.eslintignore
• ./core/modules/system/tests/modules/twig_theme_test/templates/twig_theme_test.file_url.html.twig
• ./core/modules/filter/filter.libraries.yml
• ./core/modules/locale/tests/src/Functional/LocaleJavascriptTranslationTest.php
• ./core/modules/field_ui/field_ui.libraries.yml

Leaving at Needs work for adding deprecations.

I updated the MR to add the deprecations. This is tagged for tests. What tests are needed?

Tests were asked before we had the deprecation process for files, so we're good to go here I think.

Thanks for getting this going, comment in the MR

Yes, I wasn't sure about the deprecations but went ahead anyway. Using the correct version provided I updated the other instances, and updated the 'How to deprecate' policy.

There is one failing test, core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php, which often fails for me lately although I don't see it in the list of known random failures, 🌱 [meta] Known intermittent, random, and environment-specific test failures Active

The CR still needs to be updated.

I updated the CR to the current state of the MR.

Then went hunting for *.js file not in a js directory. This command seems to work for that. They are all in tests except for core/modules/ckeditor5/webpack.config.js.

$ find core/modules -iname \*.js | sort -u | grep -v Nightwatch | grep -v "/js/"
core/modules/ckeditor5/webpack.config.js
core/modules/system/tests/modules/sdc_test/components/my-button/my-button.js
core/modules/system/tests/modules/sdc_test/components/my-cta/my-cta.js
core/modules/system/tests/modules/sdc_test_replacements/components/my-button/my-button.js
core/modules/system/tests/themes/sdc_theme_test/components/lib-overrides/lib-overrides.js

I am guessing the ones in core/modules/system/tests/modules should be moved.

Cleaned up the IS some.

Left 1 comment on the MR.

Previously rebased just to get the tests to run again and failure before was random, can't re-run manually as MR was opened by a committer.

Thanks rest looks good!

Still an issue with the library names. I updated the change record to make it easier to understand hopefully: https://www.drupal.org/node/3432773 →

@nod_, thanks for updating the CR.

Hopefully, these changes are correct.

That's my mistake also I was not aware of that @nod_

Deprecation seems to be inline with the deprecation example in the CR https://www.drupal.org/project/drupal/issues/3458589 📌 Deprecate $variables['page'] for node.html.twig Needs review

Committed e9a2e9a and pushed to 11.x. Thanks!

quietone → closed merge request !9251

Automatically closed - issue fixed for 2 weeks with no activity.