Contrib.social

EntityDefinitionUpdateManager should not fail when exceptions are thrown

Open on Drupal.org →
Created on 26 March 2015, over 10 years ago
Updated 28 February 2023, over 2 years ago

Problem/Motivation

When updating from beta 6 to 7, some of the checks that EntityDefinitionUpdateManager is doing were throwing exceptions, which breaks the whole process.

Of course, there's nothing that we can do automatically if we can't rebuild the original schema, but we should then report that and at least fix everything else. Then someone can write an update function to take care of the changes that we can't do ourself.

Proposed resolution

Catch exceptions. the current patch just silently eats errors, this is what i used to get past them, we should probably introduce a new state like DEFINITION_ERROR and then display a message for it?

Remaining tasks

Update patch
add tests
review
Commit

User interface changes

API changes

🐛 Bug report
Status

Needs work

Version

9.5

Component
Entity  →

Last updated about 5 hours ago

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 2 years ago →
    🇳🇿New Zealand quietone

    This was an issue for a bugsmash group traige meeting. I was the only one to discuss this issue.

    This is from before Drupal 8 and I am wondering if this should still be implemented? I pinged @Berdir in #bugsmash

  • Status changed to Needs work over 2 years ago
  • Comment over 2 years ago →
    🇳🇿New Zealand quietone

    @Berdir responded saying that obviously this isn't happening that often but that it is still valid and adding this would make this more resilient.

    Therefor setting back to needs works.

  • Comment over 2 years ago →
    🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

    Re-roll Patch #1 For 9.5x Dev.

  • Status changed to Needs review over 2 years ago
  • Comment over 2 years ago →
    🇮🇳India Abhisheksingh27

    Adding Reroll for Drupal 10.

  • Status changed to Needs work over 2 years ago
  • Comment over 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    #17 was tagged for tests which still needs to happen.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024