Contrib.social

Operations links on the translations overview page do not link to the correct route

Open on Drupal.org →
Created on 13 March 2015, almost 10 years ago
Updated 28 March 2024, 9 months ago

Problem/Motivation

When attempting to edit or delete a translation using the generated operation links on the translation overview page, the user is always taken to a route pertaining to the default translation.

Proposed resolution

Make the operation links on the translation overview page link to routes specific to each translation.

(An inline code comment mentions that the behavior of linking to pages for the default translation was intended for the source language only because in that case there are not specific translation pages, re-enforcing the notion that this is in fact a bug.)

Remaining tasks

TBD after subsystem maintainer review.

User interface changes

None.

API changes

None.

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Content translation  →

Last updated 2 days ago

No maintainer
Created by

🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    heddn Nicaragua

    I tend to agree with #99.

  • Comment 12 months ago →
    heddn Nicaragua

    @clayfreeman can you rebase the MR on the 11.x branch please? Or we'll have to (re)create a new branch and clone over the changes from !159.

  • Merge request !5955Operations links on the translations overview page do not link to the correct route → (Open) created by heddn
  • Status changed to RTBC 12 months ago
  • Comment 12 months ago →
    heddn Nicaragua

    Actually, I'll just open a new branch/MR, it is easy enough.

    Looks like the feedback in #99 was handled over in 🐛 Destination url query param affects on form translation delete submission Needs work . I just rebased this, nothing else. I think that means I can still RTBC this.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update 12 months ago
    28,559 pass
  • Comment 12 months ago →
    heddn Nicaragua

    heddn → changed the visibility of the branch 2451693-operations-links-on to hidden.

  • Pipeline finished with Success
    12 months ago
    Total: 482301s
    #68486
  • Issue was unassigned.
  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    🇳🇿New Zealand quietone

    I'm doing some RTBC queue triage. I read the IS and the comments. I seem to be thinking in lists today so here is what I found. I did not do a core review.

    • I did not find any unanswered questions.
    • The first thing I notice is that there are no steps to reproduce this. I tried anyway using Umami and wasn't able to reproduce the problem. I am tagging this for steps to reproduce.
    • In #32 an Issue Summary update and title change was asked for. The issue summary was updated in #70 but I don't see a title change. I am tagging for a title update. Correct me if I am wrong and I missed that it was changed. Or is this title still accurate?
    • I found manual testing and screenshots in #70. Unfortunately, the steps taken to test this were not provided. But this is the type of information that should have links in the IS so that reviewers can find it.
    • In #98 the 'Needs subsystem maintain review' tag was removed but I do not see a comment from a subsystem maintainer. Where is that comment? I am adding that tag back until there is confirmation.
    • The original approach, in #22, was changed in #46. There was no discussion about that. Is the current solution preferred over #22?
    • @joachim made a comment on a previous MR asking for comments to explain the login. Those comments still need to be added.
    • The may be a self RTBC but I have not looked closely

    I am setting to needs work for the above and un-assigning so it is clear that anyone can contribute here.

    Also, I started the test-only changes test run and the good news is that fails. And updated credit.

  • First commit to issue fork.
  • Pipeline finished with Failed
    11 months ago
    Total: 163s
    #85276
  • Comment 10 months ago →
    biancaradu27
  • Comment 9 months ago →
    connbi

    I Create a patch for drupal 10.2.3, And the #107 patch will change the node translation edit link, I revert the code.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024