- heddn Nicaragua
@clayfreeman can you rebase the MR on the 11.x branch please? Or we'll have to (re)create a new branch and clone over the changes from !159.
- Merge request !5955Operations links on the translations overview page do not link to the correct route β (Open) created by heddn
- Status changed to RTBC
11 months ago 5:53pm 26 December 2023 - heddn Nicaragua
Actually, I'll just open a new branch/MR, it is easy enough.
Looks like the feedback in #99 was handled over in π Destination url query param affects on form translation delete submission Needs work . I just rebased this, nothing else. I think that means I can still RTBC this.
- last update
11 months ago 28,559 pass - Issue was unassigned.
- Status changed to Needs work
11 months ago 8:01am 1 January 2024 - π³πΏNew Zealand quietone
I'm doing some RTBC queue triage. I read the IS and the comments. I seem to be thinking in lists today so here is what I found. I did not do a core review.
- I did not find any unanswered questions.
- The first thing I notice is that there are no steps to reproduce this. I tried anyway using Umami and wasn't able to reproduce the problem. I am tagging this for steps to reproduce.
- In #32 an Issue Summary update and title change was asked for. The issue summary was updated in #70 but I don't see a title change. I am tagging for a title update. Correct me if I am wrong and I missed that it was changed. Or is this title still accurate?
- I found manual testing and screenshots in #70. Unfortunately, the steps taken to test this were not provided. But this is the type of information that should have links in the IS so that reviewers can find it.
- In #98 the 'Needs subsystem maintain review' tag was removed but I do not see a comment from a subsystem maintainer. Where is that comment? I am adding that tag back until there is confirmation.
- The original approach, in #22, was changed in #46. There was no discussion about that. Is the current solution preferred over #22?
- @joachim made a comment on a previous MR asking for comments to explain the login. Those comments still need to be added.
- The may be a self RTBC but I have not looked closely
I am setting to needs work for the above and un-assigning so it is clear that anyone can contribute here.
Also, I started the test-only changes test run and the good news is that fails. And updated credit.
- First commit to issue fork.
I Create a patch for drupal 10.2.3, And the #107 patch will change the node translation edit link, I revert the code.