Trigger deprecation notice for old schema definition for sequence

We added this BC layer in 2015, in #2414539: Simplify schema definition for sequence → . We forgot about this, clearly. Time to get it done.

Wow — d.o weirdness because this issue hasn't been updated by a human in almost 7 years 😅

The last submitted patch, 17: 2444979-17.patch, failed testing. View results →

Yay, that found some old ones lingering!

Left one around that was added specifically for BC testing. Now verifying in a test that it triggers a deprecation 👍

+++ b/core/lib/Drupal/Core/Config/Schema/Sequence.php
@@ -28,6 +28,8 @@ protected function getElementDefinition($key) {
       $definition = $this->definition['sequence'][0];
+      $bc_sequence_location = $this->getPropertyPath();
+      @trigger_error("The definition for the '$bc_sequence_location' sequence declares the type of its items in a way that is deprecated drupal:10.1.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/2442603", E_USER_DEPRECATED);
     }

Shouldn't this be 10.2? Otherwise looks good. Deprecations from before we had a deprecation system!

The last submitted patch, 20: 2444979-20.patch, failed testing. View results →

deprecated drupal:10.1.0

The correct language would be deprecated in drupal:10.1.0 no?

#21 + #23: Double oops! Two mistakes in ~10 characters 🤣

Actually … it's been deprecated since before 8.0.0 shipped! We have a bunch more of deprecations of those days. For example: \Drupal\Core\StringTranslation\TranslationWrapper. So went with deprecated in drupal:8.0.0

Deprecations from before we had a deprecation system!

💯

Will lean on the experts seems confusing to add a deprecation for D8 but understand if deprecation wasn't a think then, (wasn't around then haha).

But LGTM.

The last submitted patch, 24: 2444979-24.patch, failed testing. View results →

Looks like an unrelated fail.

The last submitted patch, 24: 2444979-24.patch, failed testing. View results →

Another random unrelated fail.

Saving issue credit

It's nice we figured out how to do deprecations properly since 8 years ago.

Pushed to 11.x and tagging for release notes since it's weird to be adding a new deprecation message for something we deprecated in 8.0.0, so it's probably worthwhile to explicitly explain that in the release notes.

Automatically closed - issue fixed for 2 weeks with no activity.