- π¨π³China jungle Chongqing, China
Looks good, but I think
testMemoryBackendThreshold
should be moved into the new classMemoryBackendTest
fromFloodTest
.Thanks!
- Status changed to Needs review
almost 2 years ago 8:30pm 21 February 2023 - Status changed to RTBC
almost 2 years ago 1:57am 22 February 2023 - Status changed to Fixed
almost 2 years ago 9:30am 22 February 2023 - π¬π§United Kingdom catch
Committed/pushed to 10.1.x, cherry-picked back through to 9.5.x, thanks!
- Status changed to Needs work
almost 2 years ago 2:26pm 22 February 2023 - πΊπΈUnited States xjm
This broke HEAD on 10.0.x and 9.5.x with:
---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
The class is used in 10.1.x, but not 10.0.x or 9.5.x somehow. I think maybe due to changes in β¨ Add a clearByPrefix() method to the flood API Fixed that were not backported.
Marking Needs work, but if it turns out this is test coverage for something in 10.1.x only, then it would be okay not to backport this and just mark it fixed against 10.1.x.
Thanks!
- Status changed to Needs review
almost 2 years ago 2:53pm 22 February 2023 - π¬π§United Kingdom catch
Combining with @longwave's patch from π Fix unused use statement in FloodTest Closed: duplicate which should give us a clean test run against 10.0.x.
- Status changed to RTBC
almost 2 years ago 3:51pm 22 February 2023 - π¬π§United Kingdom longwave UK
RTBC, the PHPCS checks have passed on both branches.
- Status changed to Fixed
almost 2 years ago 4:09pm 22 February 2023 - π¬π§United Kingdom catch
Since I didn't actually write anything in #31, just combined two patches together, I think I'm good to commit this again, so did so to 10.0.x and 9.5.x. Thanks all.
Automatically closed - issue fixed for 2 weeks with no activity.