\Drupal\Core\Render\Renderer::doRender() could be lazier about calling Element::children()

// Get the children of the element, sorted by weight. $children = element_children($elements, TRUE); // Initialize this element's #children, unless a #pre_render callback already // preset #children. if (!isset($elements['#children'])) { $elements['#children'] = ''; } // Call the element's #theme function if it is set. Then any children of the // element have to be rendered there. If the internal #render_children // property is set, do not call the #theme function to prevent infinite // recursion. if (isset($elements['#theme']) && !isset($elements['#render_children'])) { $elements['#children'] = theme($elements['#theme'], $elements); } // If #theme was not set and the element has children, render them now. // This is the same process as drupal_render_children() but is inlined // for speed. if ($elements['#children'] === '') { foreach ($children as $key) { $elements['#children'] .= drupal_render($elements[$key]); } }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment over 1 year ago →
🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x

Patch #27 is not applied for Drupal 10.1.x so Inter-diff file is not added.

Checking patch core/lib/Drupal/Core/Render/Renderer.php...
error: while searching for:
drupal_process_states($elements);
}

// Get the children of the element, sorted by weight.
$children = Element::children($elements, TRUE);

// Initialize this element's #children, unless a #pre_render callback
// already preset #children.
if (!isset($elements['#children'])) {

error: patch failed: core/lib/Drupal/Core/Render/Renderer.php:404
error: core/lib/Drupal/Core/Render/Renderer.php: patch does not apply
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,302 pass
Status changed to Needs review over 1 year ago12:06pm 24 April 2023
Comment over 1 year ago →
🇮🇳India nikhil_110
Status changed to Needs work over 1 year ago6:05pm 6 May 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
This feels more like a feature request to me. Or something that should least have test coverage.

This was profiled 10 years ago but with the new system wonder if it should be profiled again?