Contrib.social

Clean up depth/parent/parents of taxonomy term

Open on Drupal.org →
Created on 27 April 2013, about 12 years ago
Updated 7 May 2025, 3 days ago

This is a follow-up after #1818560-92: Convert taxonomy entities to the new Entity Field API →

depth could actually be different per parent, so it might make sense to make that a property of $term->parent->depth (and $term->parent[1]->depth), which in turn would be a computed field.

vid()/id()/label() should be used when possible, in case of terms, there's the mess with taxonomy_get_tree() which this issue did *not* introduce, just used it in more places.

In e.g. an edit form for example, you don't want to edit the (possibly altered) label of a term, you want to edit the *name*, so, $term->name->value, not $term->label().

The last example there is because that class does a manual query to load terms, it was broken in HEAD, has no test coverage and this issue fixed it. Yes, it should use entity load/EFQ but that's outside the context of this issue.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

taxonomy.module

Created by

🇫🇷France andypost

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 3 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024