The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 4:31am 31 January 2023 - Status changed to Needs work
over 1 year ago 10:22pm 11 February 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
FYI didn't read all the comments but #56 appeared to be a rebase.
This could use an issue summary update as I'm not fully understanding the use case or the "why" maybe the test case will have show that. But the issue summary should mention the proposed solution and other fields per default template.
- last update
over 1 year ago 29,400 pass - Status changed to Needs review
over 1 year ago 3:21pm 31 May 2023 - 🇷🇴Romania vasike Ramnicu Valcea
Updated the MR
- Fix forphp_memory_limit
- Test for overriding PHP version and memory limitUpdate also the issue summary
- Status changed to Needs work
over 1 year ago 12:02am 1 June 2023 - 🇺🇸United States smustgrave
Cleaning up tags.
Think the last thing is to get a change record written with an example how this would be set.
- 🇷🇴Romania vasike Ramnicu Valcea
Unfortunately, i think the MR is not ready ... yet
2 things:
1. It would be nice to have also RECOMMENDED_PHP ... overridden.
2. What if the values are less than "default" - Drupal provided? Should we allow that.Another thought:
Wondering ifDrupal\Core\Utility\PhpRequirements
shouldn't be the place or getting the "right" PHP Requirements
instead ofsystem.install
...but maybe i'm just "overthinking" ...
- last update
about 1 year ago 29,499 pass