Allow install profiles to change the system requirements

Created on 3 September 2012, about 12 years ago
Updated 7 June 2023, over 1 year ago

Problem/Motivation

Some Install profiles could need more resources - PHP requirements in terms to run.
Because of
- packages/libraries used,
- amount of packages/libraries
- coding
- processes resources
So maybe we need a specific minimum PHP version and/or a specific minimum PHP memory limit.

Steps to reproduce

It's just not possible this overriding - not implemented.

Proposed resolution

Update system_requirements to get install profile "PHP requirements".
And if they exists and use them, overriding Drupal default "PHP requirements".

Remaining tasks

- Do we need a change record for this?

User interface changes

API changes

Data model changes

Release notes snippet

Original Summary report

imho there should be a way to change the constants defined for the system requirements
as 'DRUPAL_MINIMUM_PHP' or 'DRUPAL_MINIMUM_PHP_MEMORY_LIMIT'.
there could be some complex install profiles that requires "more power" from the system.
for example there's a Commerce Kickstart issue about this : #1763632: The install needs to check Kickstart requirements before starting .

Feature request
Status

Needs work

Version

11.0 🔥

Component
Install 

Last updated 2 days ago

No maintainer
Created by

🇷🇴Romania vasike Ramnicu Valcea

Live updates comments and jobs are added and updated live.
  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

    FYI didn't read all the comments but #56 appeared to be a rebase.

    This could use an issue summary update as I'm not fully understanding the use case or the "why" maybe the test case will have show that. But the issue summary should mention the proposed solution and other fields per default template.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    29,400 pass
  • Status changed to Needs review over 1 year ago
  • 🇷🇴Romania vasike Ramnicu Valcea

    Updated the MR
    - Fix for php_memory_limit
    - Test for overriding PHP version and memory limit

    Update also the issue summary

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    Cleaning up tags.

    Think the last thing is to get a change record written with an example how this would be set.

  • 🇷🇴Romania vasike Ramnicu Valcea

    Unfortunately, i think the MR is not ready ... yet

    2 things:
    1. It would be nice to have also RECOMMENDED_PHP ... overridden.
    2. What if the values are less than "default" - Drupal provided? Should we allow that.

    Another thought:
    Wondering if Drupal\Core\Utility\PhpRequirements shouldn't be the place or getting the "right" PHP Requirements
    instead of system.install ...

    but maybe i'm just "overthinking" ...

  • last update about 1 year ago
    29,499 pass
Production build 0.71.5 2024