- @quietone opened merge request.
- Status changed to Needs review
3 months ago 7:20am 18 August 2024 - 🇦🇺Australia acbramley
This looks fine, but do we really need a test for this? Surely the maxlength property is tested elsewhere?
- 🇦🇺Australia acbramley
- 🇮🇳India prashant.c Dharamshala
The
maxlength
property is working properly.
But one behavior in which if I specify the extension list comma separated such astxt,doc,docx,pdf,ppt
it auto-replacing the commas with spaces which is not a good developer experience.In addition to this if ae are replacing the commas with spaces then we need to change the description as well from
Separate extensions <strong>with a comma or space</strong>. Each extension can contain alphanumeric characters, '.', and '_', and should start and end with an alphanumeric character.
to
Separate extensions <strong>with a space</strong>. Each extension can contain alphanumeric characters, '.', and '_', and should start and end with an alphanumeric character.
- 🇺🇸United States smustgrave
@acbramley think it's worth getting this fixed and a follow up to look into deprecating #maxlength?
- 🇦🇺Australia acbramley
@smustgrave - no it's not about deprecating it, just removing the property entirely from this element, it's unnecessary afaict
- Status changed to Needs work
2 months ago 2:31pm 17 September 2024 - 🇺🇸United States smustgrave
Updated the issue summary to use the standard template.
Added remaining task to remove #maxlength
Also solution should portion should be flushed out