- πΊπΈUnited States smustgrave
Just skimming the MR 3121
There are CI failures.
The new configuration needs an upgrade path, with tests, for existing sites
Needs a change record for new setting - Merge request !3679Issue #115801: Allow password on registration without disabling e-mail verification β (Open) created by VladimirAus
- π¨πSwitzerland mistrae
The new
determineErrorRedirect
function (UserController.php) introduced in 9.5 throw anAccessDeniedHttpException
if the user in not active. This should be addressed before merging anything. - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Custom Commands Failed - π¦πΊAustralia VladimirAus Brisbane, Australia
@linhnm what are the changes in the patch?
Can you please use existing MR or at least provide interdiff for easier review?
Thank you π - last update
over 1 year ago Custom Commands Failed - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
about 1 year ago Custom Commands Failed - πΊπ¦Ukraine ershov.andrey
Make patch compatible with drupal core 10.2.3
- last update
10 months ago Patch Failed to Apply - Status changed to Needs review
6 months ago 12:29am 25 June 2024 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Can't figure out how to get it to re-test on Drupal 11β it gives me Drupal 7 only as an option?!? So seeing if setting to Needs review kicks the bots into gear.
Also, for people looking for an immediate solution the module mentioned for D7, User Registration Password (user_registrationpassword) is available and supported for modern Drupal (8, 9, 10β¦) now!
- Status changed to Needs work
6 months ago 12:37am 25 June 2024 - πΊπΈUnited States smustgrave
Should be turned to an MR. Didnβt check to see if the tags have been added
- π¦πΊAustralia VladimirAus Brisbane, Australia
VladimirAus β changed the visibility of the branch 115801-allow-password-on-register to hidden.
- π¦πΊAustralia VladimirAus Brisbane, Australia
VladimirAus β changed the visibility of the branch 10.1.x to hidden.
- π¦πΊAustralia VladimirAus Brisbane, Australia
VladimirAus β changed the visibility of the branch 115801-10.1.x-password to hidden.
- Status changed to Needs review
6 months ago 7:35am 25 June 2024 - Status changed to Needs work
6 months ago 9:29pm 4 July 2024 The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
I have created a new patch and added a new modification. For our case the register process gives access defined so had to do another change in the determineErrorRedirect on UserController.php
- π·π΄Romania adinac
Re-roll for #207
Some changes that needed to be addressed:
- in AccountSettingsForm.php the #config_target property needs to be used
- _user_mail_notify() doesn't send e-mails if \Drupal::config('user.settings')->get('notify.' . $op) is false