🇭🇰Hong Kong @yookoala

@alexpott: I don't think it is relevant if Javascript is required or not for dialog to be useful.

I am using twig template in views. I'd like to render into my view rows so I can use Javascript with them, Now this workflow is blocked by the list of allowed tags in Xss::filterAdmin(). This is the whole reason I want to introduce this tag to admin tags.

yookoala → created an issue.

Did a brief check on D9, D10 and D11 and all should work.

yookoala → created an issue.

I don't really have an MR yet.

There is no release of this module yet, but I really miss this in some of my sites. So if I make an MR of this with D10 / D11 compatibility, would you consider to create a 1.0 release out of it? (Cause I'm perfectly happy doing just that).

Oh. Sorry. Didn't know about that command :-P

Yes. They do seems to be the same thing. Will remove this module.

yookoala → created an issue.

@smustgrave My bad.

Please see the MR here:
https://git.drupalcode.org/project/drupal/-/merge_requests/8710

Hello bhavanasisarath. Just checked today and found out that I cannot create a new release in the system. Is there anyway you can grant me the permission to do so? Or can you please test and create a new release 1.0.2 (already tagged in git)?

yookoala → made their first commit to this issue’s fork.

I'm merging the changes. Thanks for contributing.

yookoala → made their first commit to this issue’s fork.

Thanks!

yookoala → changed the visibility of the branch 11.x to hidden.

yookoala → created an issue.

yookoala → created an issue.

yookoala → changed the visibility of the branch 3342417-permissions to hidden.

I'd argue approach #1 and #2 are not mutually exclusive. While approach #2 is more of a user experience concern, approach #1 makes the code more resilient and robust either way.

The fix has implemented to both 10.4.x and 11.x branch. Please review.

The implementation is done. Please help to review.

yookoala → changed the visibility of the branch 3310075-toolbar-js-errors to hidden.

yookoala → made their first commit to this issue’s fork.

Still found links that are incorrectly redirected.

"https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!ContentEnt..." is redirected to "https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...". In should instead be redirected to "https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21..." (or other URL that makes sense)

yookoala → made their first commit to this issue’s fork.

yookoala → created an issue.

yookoala → created an issue.

yookoala → created an issue.

yookoala → created an issue.

yookoala → created an issue.

Resort to a simpler fix with this merge request.

The issue still persist in v10.0.0

Is there anything we can speed up the release for D10? Is there anything blocking?

Sorry about the "composer require failure" tests, but they are failed because incorrect PHP version (<8.1.0) paring with D10.

Drupal 9 has been deprecated. Please release this as soon as possible.

Please remove the dependency.

drupal/better_exposed_filters 6.0.2 requires drupal/jquery_ui_slider ^1.1, that is not compatible with Drupal 10. This dependency is now blocking my site upgrade. If the dependency is not necessary in the first place, it is only sensible to remove it.

@apaderno: Is there any update to this yet? Please advice how we should proceed next.

With the co-maintain permission, I don't seem to have ability to merge MR from other users. I'd prefer to be able to do that with maintainer permission, if that's what required.

Might I add the title was changed 2 months ago in the project's issue tracker (as shown here). It was not changed when the issue is was moved.

I've sent private message and opened issue more than 2 weeks ago now. I've received no reply from the project owner.

Please let me know how I might proceed to maintain or take ownership of the project

Project link:
https://www.drupal.org/project/filter_twig →

Thanks.

yookoala → created an issue.

Implemented the change I mentioned. Please check if this is good enough for production. Thanks.

If things go right, I should be able to create a new sub theme by running this in bash with drush:

drush php:eval "
$m = new \Drupal\bootstrap5\SubthemeManager(\Drupal::getContainer()->get('file_system'), \Drupal::getContainer()->get('messenger'));
echo $m->createSubtheme('mysubtheme', 'My Bootstrap 5 Subtheme', 'themes/custom');
"

yookoala → created an issue.

I have freshly installed views_show_more on Drupal 10.1.3. And I've setup a very simple view to use the Views Show More pager. When I clicked the "Show More" link, the browser refreshed into another page. This is not supposed to happen.

I've disabled Javascript caching. Then I've added a single console.log on top of Drupal.AjaxCommands.prototype.viewsShowMore. I don't think that console log is ever run after I clicked the "Show More" link in pager.

yookoala → created an issue.

Released the changes here to 2.0.0-alpha2.
https://www.drupal.org/project/most_viewed/releases/2.0.0-alpha2 →

yookoala → created an issue.