🇧🇪Belgium @nonom

Thanks devad → ,

The change was reverted in the 3.0.x branch,

https://git.drupalcode.org/project/mobile_detect/-/commit/1d1404897eebd2...

Patch #10 works for me. Thanks.

Thanks @Nelo_Drup, I'll check it and update the documentation.

Fixed in both branches 3.x and 4.x. Please test.

Works for me, and the service is defined in mobile_detect.services.yml.

  cache_context.mobile_detect_device_type:
    class: Drupal\mobile_detect\Cache\Context\DeviceTypeCacheContext
    arguments: ["@mobile_detect"]
    tags:
      - { name: cache.context }

Could you try to refresh the cache and let me know.

I tried to reproduce your problem and I was waiting any other feedback, please try the latest release and let me know if you still having the same issue.

I started the new 4.x branch, thanks!
Please check 📌 Update mobiledetectlib dependency Needs review

Needs testing it's using 4.8.x
https://www.drupal.org/project/mobile_detect/releases/4.0.x-dev →

Fixed in 3.0.5. Thanks!

nonom → created an issue.

We are moving to Drupal 10 with full support for 8.1.20+

I tried a few times and I cannot reproduce the error. It works for me.

If the problem persists please feel free to reopen this issue.

It needs to be installed with composer to download the library into the /vendor folder.

Please be sure downloading the mobiledetect library using composer to avoid any problem.

Thanks for contrib. +1

My issue was generating the Cookies from Varnish, related with #2884028: Problem with cookies →

From the Legal module README

VARNISH
Add Legal module's cookies to the Varnish whitelist. 

Thanks #1

It's probably affecting to any comparision so I did a quick patch (needs work) If anyone have the same issue like me trying fire the proper state at page load with a given condition.

On my case a field should be visible or not visible depending the chosen value from a multiselect. But loading the page doesn't fire the proper state. Actually only works for me with single selects, but not for complex multi selects. So the comparators have sense to be added earlier.

Patch attached as proof of concept.

The proposed solution works for me.

In Drupal 8+ you can try the following:

$md = \Drupal::service('mobile_detect');
$md->isMobile();
$md->isTablet();

Updated with the proper syntax.
https://git.drupalcode.org/project/mobile_detect/-/commit/016534574774ac...

Updated README.md with the proper syntax.
https://git.drupalcode.org/project/mobile_detect/-/commit/016534574774ac...

Also added in 3.0.x branch
https://git.drupalcode.org/project/mobile_detect/-/commit/5ceed26cfaf181...

I was debugging #3 because wasn't working for me. It seems the value to fill was in e.effect.options.fill instead e.effect.fill.

Once replaced the e.effect.fill references by e.effect.options.fill it worked.

Thanks, patch attached.

I'm having also this issue.

The issue persists in Drupal 10.1.0 for a multilingual profile installation.

Reopening I thought was merged.

It's done.
The bot only parses one time on each major release.
In example D11.

Thanks for the contribution.

Hi @kazah we haven't already an alpha release but a dev branch.

We are working testing on huge sites and trying to get the best approach for this, I guess it will be released soon (tm) ;-)

Contributions are always welcome!

The branch 8.x1.x-dev still in development,

It will be released for ^8 || ^9 || ^10 as soon as possible.

I did a full review over the options

- Boost Path Cacheability Settings
If I hide the following page:

Still being generated but not served which is good.

- The count pages doesn't works for me but not a big issue at all.
- The Purge is working from my side.
- The Generate all pages probably is not fulling working, get in mind the feedback messages which aren't clear at all.
- I did not tested the XML sitemap options there are many settings features involved on this branch.

By other side,

The multilingual seems working but seems not working fully caching pages without the multilingual feature.

I think we have many options to test so an alpha version could help to start contributing on.

By other side thanks for the full classes documentation they looks so fine :)

@C-Logemann Could I work on the same branch ?

Works for me.

That are good news!, back to review!

Just a suggestion. I've noticed the site is in maintenance mode generating all the URLs in the batch proccess. Maybe we would like to avoid this; because if it fails, the site still in maintenance.

Enabling the module via drush I'm getttng this error:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
  The service "boost.command" has a dependency on a non-existent service "logger.channel.linkchecker".

I'm experiencing the same issue here.