- 🇧🇪Belgium nonom Brussels
Enabling the module via drush I'm getttng this error:
In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86: The service "boost.command" has a dependency on a non-existent service "logger.channel.linkchecker".
- Status changed to Needs work
almost 2 years ago 1:36pm 28 January 2023 - 🇩🇪Germany c-logemann Frankfurt/M, Germany
Oh that's a bad copy paste error. Will fix this soon. Until then code should be work when also linkchecker module is installed.
- Status changed to Needs review
almost 2 years ago 2:51pm 28 January 2023 - 🇩🇪Germany c-logemann Frankfurt/M, Germany
I use a clone of a bigger drupal system especially because of performance improvements. Now I installed a vanilla Drupal beside to avoid errors like this. The logger bug is now fixed with last commit.
- 🇧🇪Belgium nonom Brussels
That are good news!, back to review!
Just a suggestion. I've noticed the site is in maintenance mode generating all the URLs in the batch proccess. Maybe we would like to avoid this; because if it fails, the site still in maintenance.
- 🇧🇪Belgium nonom Brussels
I did a full review over the options
- Boost Path Cacheability Settings
If I hide the following page:
Still being generated but not served which is good.
- The count pages doesn't works for me but not a big issue at all.
- The Purge is working from my side.
- The Generate all pages probably is not fulling working, get in mind the feedback messages which aren't clear at all.
- I did not tested the XML sitemap options there are many settings features involved on this branch.By other side,
The multilingual seems working but seems not working fully caching pages without the multilingual feature.
I think we have many options to test so an alpha version could help to start contributing on.
By other side thanks for the full classes documentation they looks so fine :)
@C-Logemann Could I work on the same branch ?
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 2:03pm 14 February 2023 - 🇩🇪Germany c-logemann Frankfurt/M, Germany
@nonom Sorry for the delay. AFAIK it should be possible for you to work on the same branch. And in any case this would be OK for me.
- Assigned to nonom
- 🇩🇪Germany c-logemann Frankfurt/M, Germany
@nonom I wanted to move on a little bit this weekend especially with this issue. So thanks for your review so far. I know that the reporting of the cache warming parts are not very consistent. But that is not a blocker to merge the major improvements.
> I noticed the site is on maintenance mode starting the "Generate all the URLs" batch process.
Oh I didn't recognized this. And I agree we should fix this. When it's an easy fix I will directly include it. If not we can open a new issue for that.
- Assigned to c-logemann
- 🇩🇪Germany c-logemann Frankfurt/M, Germany
I tested again especially the sitemap part and I think everything what's left is only a minor problem. So I will finally merge the current code because it's better as without. So let's create extra issues on the other minor points.
Some response from my to today test:
- I cannot reproduce the Maintenenace problem.
- The page count currently don't work for one file for me.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @c-logemann opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
C-Logemann →
committed ece89786 on 8.x-1.x
Issue #3323668 by C-Logemann, nonom: Manage CacheGenerate and CachePurge...
-
C-Logemann →
committed ece89786 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 4:52pm 28 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.