ieguskiza → credited Pol → .
Why do you need a patch?
Why don't you use the URL gitlab provides: https://git.drupalcode.org/project/views_term_hierarchy_weight_field/-/c...
Hello,
Yes it needs a maintainer.
No that's wrong. You CAN actually target a specific change in Gitlab.
For example, the commit you just created in your MR, add a `.patch` at the end, and you have your patch!
=> https://git.drupalcode.org/project/views_parity_row/-/commit/7e3d97c8e3c...
The MR has been merged already, what are you talking about?
Hi,
What are the advantages of providing a patch, it gives you more work, no? What are the benefits?
Anyway, could you please provide a MR instead so we can review/merge it?
Thanks!
Hello,
Since November 2020, drupal is using Gitlab as VCS.
Therefore, could you please submit a merge request instead of a patch?
Thanks.
@Jeya sundhar: Could you double check if you haven't missed anything?
@frankdesign: Are you able to spot the issue while tweaking a bit the changes that were introduced ?
Can you please use english?
Hi !
Thanks for your patch. Could you please stop posting patches and provide a merge request through Gitlab?
Thanks again!
Cool, thanks!
Hi,
Though I don't use Slack very often, I have indeed received the notification.
I understand your eagerness to maintain the project, and I appreciate your initiative. However, I noticed that you've been working with Drupal for only three weeks. While your enthusiasm is commendable, I must admit I'm a bit apprehensive about entrusting the project to someone who's been registered for such a short time. This concern leads me to suggest a more gradual approach.
How about we start by having you submit pull/merge requests for some initial tasks? After some time and successful collaboration, we can re-evaluate your involvement and possibly expand your responsibilities.
Please let me know if this approach works for you or if you have any questions or concerns.
Regards
Hi !
Thanks for proposing to maintain one of my module.
I just gave you the right permissions, make it good use :)
Dear Eason,
Can you explain what is this patch and why you posted it here in a closed issue ?
Hello,
I carefully checked the page at https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-... → , and I observed that there is no strict requirement regarding capitalization of the module name.
Hence, I have decided to close this issue. I kindly request that you refrain from submitting similar pull requests in the future.
Thank you.
Should be fixed by now ! Sorry for the delay.
Woopsie! Fixing the issue right now.
Hey,
Since 2020, the time I wrote the initial message, a few things has been updated and I wanted to add a few more information here.
First, I released ecphp/cas-lib version 2. The release 2 has been a complete refactoring and rewrite of the library, removing the things that was making the library stateful. Basically, in Version 1, the request had to be injected in the constructor, making the binding in the container a bit more complex. In Version 2, the request is injected in the methods we call from the library (login, logout, serviceValidate, etc etc).
Then, very recently, a Laravel package has been created, it's available at: https://github.com/ecphp/laravel-cas
We have now 2 packages on top of `ecphp/cas-lib`, one for Symfony and one for Laravel.
Also, the links in the bottom of the original message are no more available since Heroku is no more free.
I still believe that using an external library to handle the CAS protocol would be a good idea in this project, since it would make things clearer. The Drupal module would act as the glue code between Drupal and `ecphp/cas-lib`, just like the packages for Symfony and Laravel.
Let me know if I can be of any help.
Bye!