- Issue created by @joelseguin
- 🇦🇺Australia acbramley
I believe this is a core issue that was caused by 🐛 (Re-)Add width / height also on fallback image Fixed
- 🇮🇳India Jeya sundhar Coimbatore
Jeya sundhar → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 year ago 3:01pm 19 September 2023 - last update
about 1 year ago 1 pass - 🇨🇦Canada joelseguin Ontario, Canada
Thanks @Jeya sundhar - I can confirm that the patch worked perfectly after testing against the same site making use of the "Responsive background image" formatter.
- last update
about 1 year ago 1 pass - @jeya-sundhar opened merge request.
- last update
about 1 year ago 1 pass - 🇮🇳India Jeya sundhar Coimbatore
Hi @Pol Dellaiera
Thanks for the review.
Condition updated. file_exists checked before getting image size. :) - last update
about 1 year ago 1 pass - 🇮🇳India Jeya sundhar Coimbatore
Hi @Pol Dellaiera
Proposal of something smaller without almost no local variables changes updated. :+1 - last update
about 1 year ago 1 pass - last update
about 1 year ago 1 pass - 🇮🇳India Jeya sundhar Coimbatore
Hi @Pol Dellaiera :)
$uri used instead of $url. Coding standard fixes updated :+1 -
Pol →
committed f7d3bbc7 on 8.x-1.x authored by
Jeya sundhar →
Issue #3375638: Undefined array key "height" and "width" when using "...
-
Pol →
committed f7d3bbc7 on 8.x-1.x authored by
Jeya sundhar →
- 🇮🇪Ireland frankdesign
Patch is not working for me I'm afraid. I applied it today to 8.x-1.16 on Drupal 10.1.4 and PHP 8.1.24
Before the patch, I was getting the same error as above.
After the patch (which applies no problem), there is no error but no background image appears. There is no error in the logs either.
Am I missing something? Is there a setting I need to change somewhere?
P.S. I have Responsive Background Images working fine on all my other sites which are still D9.5
- 🇧🇪Belgium Pol Brussels
@Jeya sundhar: Could you double check if you haven't missed anything?
@frankdesign: Are you able to spot the issue while tweaking a bit the changes that were introduced ?
- 🇨🇦Canada joelseguin Ontario, Canada
@frankdesign the latest patch (from MR 6) is working nicely for me. No errors in the logs. Both background image and responsive background image formatters work as expected with background images appearing on the frontend of the site.
- 🇮🇪Ireland frankdesign
My bad. I found a change (as part of upgrading to D10) in the theme template files for Media that prevented Background Images Formatter from working. Once I fixed that, both background image and responsive background image formatters are working perfectly after applying the patch.
Thanks @Pol and @joelseguin for confirming it was working for you.
F
- 🇺🇸United States alex.verhoeven
Patch is also working well for me. Any chance we can get this merged? It would wonderful to kill these warnings.
Thanks for working on this for us!
- 🇧🇪Belgium Pol Brussels
The MR has been merged already, what are you talking about?
- 🇺🇸United States alex.verhoeven
My apologies, Pol, I misspoke! I meant rolled into a new release for use in production.
- Status changed to Fixed
about 1 year ago 11:27pm 14 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.